From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeff Davis <jdavis@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Handle the "und" locale in ICU versions 54 and older.
Date: Thu, 23 Mar 2023 13:25:41 -0400
Message-ID: <1862096.1679592341@sss.pgh.pa.us> (raw)
In-Reply-To: <E1pfORi-005115-Gc@gemulon.postgresql.org>
References: <E1pfORi-005115-Gc@gemulon.postgresql.org>
Jeff Davis <jdavis@postgresql.org> writes:
> Handle the "und" locale in ICU versions 54 and older.
> The "und" locale is an alternative spelling of the root locale, but it
> was not recognized until ICU 55. To maintain common behavior across
> all supported ICU versions, check for "und" and replace with "root"
> before opening.
> Previously, the lack of support for "und" was dangerous, because
> versions 54 and older fall back to the environment when a locale is
> not found. If the user specified "und" for the language (which is
> expected and documented), it could not only resolve to the wrong
> collator, but it could unexpectedly change (which could lead to
> corrupt indexes).
Hmm, should we back-patch this? Seems like existing branches would
be even more at risk than v16, because more likely to be built with
old ICU. OTOH, we do also run the risk of breaking installations
that weren't broken before.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, jdavis@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Handle the "und" locale in ICU versions 54 and older.
In-Reply-To: <1862096.1679592341@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox