pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andrey Borodin <x4mmm@yandex-team.ru>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Amit Kapila <akapila@postgresql.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Prevent invalidation of newly synced replication slots.
Date: Wed, 28 Jan 2026 15:44:41 +0500
Message-ID: <1DF1F535-4027-4F33-98B5-7577D11053C9@yandex-team.ru> (raw)
In-Reply-To: <CAA4eK1KU_q0mCwSOL3G5O7DH0DA4DKv8jvQy-O6pyt2eQUqpmA@mail.gmail.com>
References: <E1vkc3p-002uNr-0e@gemulon.postgresql.org>
	<CA+TgmobdVhO0ckZfsBZ0wqDO4qHVCwZZx8sf=EinafvUam-dsQ@mail.gmail.com>
	<CA+hUKGJotCdMdhrwVST4xbsPzr-csDgzveNhKu4UAXEmCDJ4iA@mail.gmail.com>
	<jqliu25wuvlxcjybekrpvmflgaod4iytlwekjyag2q43ml76fg@tfna2hbyhw4s>
	<CA+TgmobkmUMBocv0hxKiBj_5ZoTRE=qPz7QOu7voJ_j=dWNaaA@mail.gmail.com>
	<CA+Tgmoa-RYWEkZi6tpp9TLrD+1kKFgxR6kgXCCiomMyDnh+ENw@mail.gmail.com>
	<CAA4eK1KU_q0mCwSOL3G5O7DH0DA4DKv8jvQy-O6pyt2eQUqpmA@mail.gmail.com>



> On 28 Jan 2026, at 10:47, Amit Kapila <amit.kapila16@gmail.com> wrote:
> 
> Do let me know if you could think of gathering any other information
> which can be of help here.

Interestingly, increasing timeout in pgrename() to 500 seconds fixes "Windows - Server 2022, VS 2019 - Meson & ninja ", but does not fix "Windows - Server 2022, VS 2019 - Meson & ninja".


inline patch 1: src/port/dirmod.c (+1/-1 lines) download inline-1.patchdiff --git a/src/port/dirmod.c b/src/port/dirmod.c
index 467b50d6f09..da38e37aa45 100644
--- a/src/port/dirmod.c
+++ b/src/port/dirmod.c
@@ -88,7 +88,7 @@ pgrename(const char *from, const char *to)
                        return -1;
 #endif
-               if (++loops > 100)              /* time out after 10 sec */
+               if (++loops > 5000)             /* time out after 10 sec */
                        return -1;
                pg_usleep(100000);              /* us */
        }



Best regards, Andrey Borodin.




view thread (31+ messages)  latest in thread

Message-ID: <1DF1F535-4027-4F33-98B5-7577D11053C9@yandex-team.ru>
Permalink:  ../1DF1F535-4027-4F33-98B5-7577D11053C9@yandex-team.ru/
Also on:    postgresql.org/message-id/1DF1F535-4027-4F33-98B5-7577D11053C9@yandex-team.ru

 ·  · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: x4mmm@yandex-team.ru, amit.kapila16@gmail.com, robertmhaas@gmail.com, andres@anarazel.de, thomas.munro@gmail.com, akapila@postgresql.org, pgsql-hackers@lists.postgresql.org
  Subject: Re: pgsql: Prevent invalidation of newly synced replication slots.
  In-Reply-To: <1DF1F535-4027-4F33-98B5-7577D11053C9@yandex-team.ru>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox