pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Add a comment documenting the question of whether PrefetchBuffer
2+ messages / 2 participants
[nested] [flat]
* pgsql: Add a comment documenting the question of whether PrefetchBuffer
@ 2009-04-03 18:17 Tom Lane <tgl@postgresql.org>
0 siblings, 0 replies; 2+ messages in thread
From: tgl@postgresql.org @ 2009-04-03 18:17 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Add a comment documenting the question of whether PrefetchBuffer should
try to protect an already-existing buffer from being evicted. This was
left as an open issue when the posix_fadvise patch was committed. I'm
not sure there's any evidence to justify more work in this area, but we
should have some record about it in the source code.
Modified Files:
--------------
pgsql/src/backend/storage/buffer:
bufmgr.c (r1.250 -> r1.251)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/storage/buffer/bufmgr.c?r1=1.250&r2=1...)
^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Release PQconninfoOptions array in GetDbnameFromConnectionOption
@ 2024-03-24 16:31 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 2+ messages in thread
From: Tom Lane @ 2024-03-24 16:31 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Release PQconninfoOptions array in GetDbnameFromConnectionOptions().
It wasn't getting freed in one code path, which Coverity identified as
a resource leak. It's probably of little consequence, but re-ordering
the code into the correct sequence is no more work than dismissing the
complaint. Minor oversight in commit a145f424d.
While here, improve the unreasonably clunky coding of
FindDbnameInConnParams: use of an output parameter is unnecessary
and prone to uninitialized-variable problems.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d37e0d0c50ee560fa2e7dc2a4dc904a885957985
Modified Files
--------------
src/bin/pg_basebackup/streamutil.c | 29 ++++++++++++++---------------
1 file changed, 14 insertions(+), 15 deletions(-)
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-03-24 16:31 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-04-03 18:17 pgsql: Add a comment documenting the question of whether PrefetchBuffer Tom Lane <tgl@postgresql.org>
2024-03-24 16:31 pgsql: Release PQconninfoOptions array in GetDbnameFromConnectionOption Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox