From: alvherre@postgresql.org
To: pgsql-committers@postgresql.org
Subject: pgsql: Disallow setting fillfactor for TOAST tables.
Date: Sat, 4 Apr 2009 00:45:02 +0000 (UTC)
Message-ID: <20090404004502.81A0D754ADE@cvs.postgresql.org> (raw)
Log Message:
-----------
Disallow setting fillfactor for TOAST tables.
To implement this without almost duplicating the reloption table, treat
relopt_kind as a bitmask instead of an integer value. This decreases the
range of allowed values, but it's not clear that there's need for that much
values anyway.
This patch also makes heap_reloptions explicitly a no-op for relation kinds
other than heap and TOAST tables.
Patch by ITAGAKI Takahiro with minor edits from me. (In particular I removed
the bit about adding relation kind to an error message, which I intend to
commit separately.)
Modified Files:
--------------
pgsql/src/backend/access/common:
reloptions.c (r1.24 -> r1.25)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/common/reloptions.c?r1=1.24&r2...)
pgsql/src/include/access:
reloptions.h (r1.13 -> r1.14)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/access/reloptions.h?r1=1.13&r2=1.14)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: alvherre@postgresql.org
Subject: Re: pgsql: Disallow setting fillfactor for TOAST tables.
In-Reply-To: <20090404004502.81A0D754ADE@cvs.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox