From: Bruce Momjian <bruce@momjian.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Re: [COMMITTERS] pgsql: Initialise perl library as documented in perl API.
Date: Fri, 5 Jun 2009 09:53:53 -0400 (EDT)
Message-ID: <200906051353.n55Drrd18136@momjian.us> (raw)
In-Reply-To: <4A292199.6030201@dunslane.net>
Andrew Dunstan wrote:
> [hours of digging later]
>
> On FBSD at least, this is failing in the function Perl_do_taint(). I
> can't see anything too terrible in the source for this, but to dig
> further I'd have to build another perl with debugging turned on. Anyway,
> it turns out that this actually isn't called at all if Perl is
> configured to use its own malloc() routines instead of those supplied by
> the system, as is the case on Fedora, for example, but not FBSD.
>
> So we have a bit of a dilemma. We know that this initialization is
> required by the Perl API, and we know that some platforms fail without
> it, and we also know that this fails on some platforms which use the
> system's malloc() for perl.
>
> I think we need to float a bug upstream to the perl guys on this, but as
> a holding position I suggest that we alter the #ifdef test to avoid
> calling PERL_SYS_INIT3() where MYMALLOC is defined. It's ugly, but I
> can't think of another simple way around it (and we've done worse things
> to accommodate platform weirdness ;-) )
>
> BTW, it's not caused by passing NULL as the third argument of
> PERL_SYS_INIT3() - changing that was the first thing I tried.
I think with an extensive C comment that is acceptable at this point, at
least until we hear from the perl guys. I would think projects would
have hit this issue too.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: bruce@momjian.us, andrew@dunslane.net, tgl@sss.pgh.pa.us, pgsql-hackers@postgresql.org
Subject: Re: Re: [COMMITTERS] pgsql: Initialise perl library as documented in perl API.
In-Reply-To: <200906051353.n55Drrd18136@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox