pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Ensure xmlFree(NULL) is a no-op instead of a core dump.
3+ messages / 2 participants
[nested] [flat]
* pgsql: Ensure xmlFree(NULL) is a no-op instead of a core dump.
@ 2009-06-10 03:44 Tom Lane <tgl@postgresql.org>
0 siblings, 0 replies; 3+ messages in thread
From: tgl@postgresql.org @ 2009-06-10 03:44 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Ensure xmlFree(NULL) is a no-op instead of a core dump. Per report from
Sergey Burladyan, there are at least some dank corners of libxml2 that
assume this behavior, even though their published documentation suggests
they shouldn't.
This is only really a live problem in 8.3, but the code is still there
for possible debugging use in HEAD, so patch both branches.
Modified Files:
--------------
pgsql/src/backend/utils/adt:
xml.c (r1.90 -> r1.91)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/xml.c?r1=1.90&r2=1.91)
^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Ensure xmlFree(NULL) is a no-op instead of a core dump.
@ 2009-06-10 03:44 Tom Lane <tgl@postgresql.org>
0 siblings, 0 replies; 3+ messages in thread
From: tgl@postgresql.org @ 2009-06-10 03:44 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Ensure xmlFree(NULL) is a no-op instead of a core dump. Per report from
Sergey Burladyan, there are at least some dank corners of libxml2 that
assume this behavior, even though their published documentation suggests
they shouldn't.
This is only really a live problem in 8.3, but the code is still there
for possible debugging use in HEAD, so patch both branches.
Tags:
----
REL8_3_STABLE
Modified Files:
--------------
pgsql/src/backend/utils/adt:
xml.c (r1.68.2.9 -> r1.68.2.10)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/xml.c?r1=1.68.2.9&r2=1.68.2...)
^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix code for probing availability of AVX-512.
@ 2024-04-23 15:55 Nathan Bossart <nathan@postgresql.org>
0 siblings, 0 replies; 3+ messages in thread
From: Nathan Bossart @ 2024-04-23 15:55 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix code for probing availability of AVX-512.
This commit fixes a few things:
* Instead of checking for CPU support of the "xsave" extension, we
need to check for OS support of XGETBV instructions via the
"osxsave" flag.
* We must check that additional XCR0 bits are set to be sure the
ZMM registers are fully enabled.
* We should use the recommended ordering of steps. Specifically,
we need to check that the ZMM registers are enabled prior to
checking for AVX-512 via CPUID.
In passing, split this code into separate functions to improve
readability.
Reported-by: Andrew Kane
Reviewed-by: Akash Shankaran, Raghuveer Devulapalli
Discussion: https://postgr.es/m/20240418024459.GA3385227%40nathanxps13
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/598e0114a3b16bb7edcaba6784b3794f816889ae
Modified Files
--------------
src/port/pg_popcount_avx512_choose.c | 80 +++++++++++++++++++++---------------
1 file changed, 47 insertions(+), 33 deletions(-)
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2024-04-23 15:55 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-06-10 03:44 pgsql: Ensure xmlFree(NULL) is a no-op instead of a core dump. Tom Lane <tgl@postgresql.org>
2009-06-10 03:44 pgsql: Ensure xmlFree(NULL) is a no-op instead of a core dump. Tom Lane <tgl@postgresql.org>
2024-04-23 15:55 pgsql: Fix code for probing availability of AVX-512. Nathan Bossart <nathan@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox