pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: tgl@postgresql.org
To: pgsql-committers@postgresql.org
Subject: pgsql: Fix things so that array_agg_finalfn does not modify or free its
Date: Sat, 20 Jun 2009 18:45:28 +0000 (UTC)
Message-ID: <20090620184528.6872875331E@cvs.postgresql.org> (raw)

Log Message:
-----------
Fix things so that array_agg_finalfn does not modify or free its input
ArrayBuildState, per trouble report from Merlin Moncure.  By adopting
this fix, we are essentially deciding that aggregate final-functions
should not modify their inputs ever.  Adjust documentation and comments
to match that conclusion.

Modified Files:
--------------
    pgsql/doc/src/sgml:
        xaggr.sgml (r1.37 -> r1.38)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/xaggr.sgml?r1=1.37&r2=1.38)
    pgsql/src/backend/executor:
        nodeWindowAgg.c (r1.5 -> r1.6)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeWindowAgg.c?r1=1.5&r2=1....)
    pgsql/src/backend/utils/adt:
        array_userfuncs.c (r1.30 -> r1.31)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/array_userfuncs.c?r1=1.30&r...)
        arrayfuncs.c (r1.157 -> r1.158)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/arrayfuncs.c?r1=1.157&r2=1....)




view thread (2+ messages)  latest in thread

Message-ID: <20090620184528.6872875331E@cvs.postgresql.org>
Permalink:  ../20090620184528.6872875331E@cvs.postgresql.org/
Also on:    postgresql.org/message-id/20090620184528.6872875331E@cvs.postgresql.org

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@postgresql.org
  Subject: Re: pgsql: Fix things so that array_agg_finalfn does not modify or free its
  In-Reply-To: <20090620184528.6872875331E@cvs.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox