pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Need to use pg_perm_setlocale when setting LC_CTYPE and
3+ messages / 2 participants
[nested] [flat]

* pgsql: Need to use pg_perm_setlocale when setting LC_CTYPE and
@ 2009-07-08 17:53  Heikki Linnakangas <heikki@postgresql.org>
  0 siblings, 0 replies; 3+ messages in thread

From: heikki@postgresql.org @ 2009-07-08 17:53 UTC (permalink / raw)
  To: pgsql-committers

Log Message:
-----------
Need to use pg_perm_setlocale when setting LC_CTYPE and LC_COLLATE at startup.
Otherwise, the LC_CTYPE/COLLATE setting gets reverted when using plperl, which
leads to incorrect query results and index corruption.

This was accidentally broken in the per-database locale patch in 8.4. Pointed
out by Andrew Gierth.

Modified Files:
--------------
    pgsql/src/backend/utils/init:
        postinit.c (r1.191 -> r1.192)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/init/postinit.c?r1=1.191&r2=1.1...)




^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* pgsql: Need to use pg_perm_setlocale when setting LC_CTYPE and
@ 2009-07-08 17:53  Heikki Linnakangas <heikki@postgresql.org>
  0 siblings, 0 replies; 3+ messages in thread

From: heikki@postgresql.org @ 2009-07-08 17:53 UTC (permalink / raw)
  To: pgsql-committers

Log Message:
-----------
Need to use pg_perm_setlocale when setting LC_CTYPE and LC_COLLATE at startup.
Otherwise, the LC_CTYPE/COLLATE setting gets reverted when using plperl, which
leads to incorrect query results and index corruption.

This was accidentally broken in the per-database locale patch in 8.4. Pointed
out by Andrew Gierth.

Tags:
----
REL8_4_STABLE

Modified Files:
--------------
    pgsql/src/backend/utils/init:
        postinit.c (r1.191 -> r1.191.2.1)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/init/postinit.c?r1=1.191&r2=1.1...)




^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* pgsql: Put genbki.pl output into src/include/catalog/ directly
@ 2024-03-14 06:15  Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 3+ messages in thread

From: Peter Eisentraut @ 2024-03-14 06:15 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Put genbki.pl output into src/include/catalog/ directly

With the makefile rules, the output of genbki.pl was written to
src/backend/catalog/, and then the header files were linked to
src/include/catalog/.

This changes it so that the output files are written directly to
src/include/catalog/.  This makes the logic simpler, and it also makes
the behavior consistent with the meson build system.  Also, the list
of catalog files is now kept in parallel in
src/include/catalog/{meson.build,Makefile}, while before the makefiles
had it in src/backend/catalog/Makefile.

Reviewed-by: Andreas Karlsson <andreas@proxel.se>
Discussion: https://www.postgresql.org/message-id/flat/21b74bdc-183d-4dd5-9c27-9378d178f459@eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6ab2e8385d55e0b73bb8bbc41d9c286f5f7f357f

Modified Files
--------------
src/backend/Makefile             |   2 +-
src/backend/catalog/.gitignore   |   8 ---
src/backend/catalog/Makefile     | 140 +-----------------------------------
src/include/Makefile             |   7 +-
src/include/catalog/.gitignore   |   4 +-
src/include/catalog/Makefile     | 152 +++++++++++++++++++++++++++++++++++++++
src/include/catalog/meson.build  |   3 +-
src/tools/pginclude/headerscheck |   2 -
8 files changed, 163 insertions(+), 155 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2024-03-14 06:15 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-07-08 17:53 pgsql: Need to use pg_perm_setlocale when setting LC_CTYPE and Heikki Linnakangas <heikki@postgresql.org>
2009-07-08 17:53 pgsql: Need to use pg_perm_setlocale when setting LC_CTYPE and Heikki Linnakangas <heikki@postgresql.org>
2024-03-14 06:15 pgsql: Put genbki.pl output into src/include/catalog/ directly Peter Eisentraut <peter@eisentraut.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox