From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Put genbki.pl output into src/include/catalog/ directly
Date: Thu, 14 Mar 2024 06:15:38 +0000
Message-ID: <E1rkeNO-003iis-9I@gemulon.postgresql.org> (raw)
Put genbki.pl output into src/include/catalog/ directly
With the makefile rules, the output of genbki.pl was written to
src/backend/catalog/, and then the header files were linked to
src/include/catalog/.
This changes it so that the output files are written directly to
src/include/catalog/. This makes the logic simpler, and it also makes
the behavior consistent with the meson build system. Also, the list
of catalog files is now kept in parallel in
src/include/catalog/{meson.build,Makefile}, while before the makefiles
had it in src/backend/catalog/Makefile.
Reviewed-by: Andreas Karlsson <andreas@proxel.se>
Discussion: https://www.postgresql.org/message-id/flat/21b74bdc-183d-4dd5-9c27-9378d178f459@eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/6ab2e8385d55e0b73bb8bbc41d9c286f5f7f357f
Modified Files
--------------
src/backend/Makefile | 2 +-
src/backend/catalog/.gitignore | 8 ---
src/backend/catalog/Makefile | 140 +-----------------------------------
src/include/Makefile | 7 +-
src/include/catalog/.gitignore | 4 +-
src/include/catalog/Makefile | 152 +++++++++++++++++++++++++++++++++++++++
src/include/catalog/meson.build | 3 +-
src/tools/pginclude/headerscheck | 2 -
8 files changed, 163 insertions(+), 155 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Put genbki.pl output into src/include/catalog/ directly
In-Reply-To: <E1rkeNO-003iis-9I@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox