pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Repair bug #4926 "too few pathkeys for mergeclauses".
4+ messages / 2 participants
[nested] [flat]
* pgsql: Repair bug #4926 "too few pathkeys for mergeclauses".
@ 2009-07-17 23:19 Tom Lane <tgl@postgresql.org>
0 siblings, 0 replies; 4+ messages in thread
From: tgl@postgresql.org @ 2009-07-17 23:19 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Repair bug #4926 "too few pathkeys for mergeclauses". This example shows
that the sanity checking I added to create_mergejoin_plan() in 8.3 was a
few bricks shy of a load: the mergeclauses could reference pathkeys in a
noncanonical order such as x,y,x, not only cases like x,x,y which is all
that the code had allowed for. The odd cases only turn up when using
redundant clauses in an outer join condition, which is why no one had
noticed before.
Modified Files:
--------------
pgsql/src/backend/optimizer/path:
pathkeys.c (r1.97 -> r1.98)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/path/pathkeys.c?r1=1.97&r2=...)
pgsql/src/backend/optimizer/plan:
createplan.c (r1.260 -> r1.261)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/plan/createplan.c?r1=1.260&...)
pgsql/src/test/regress/expected:
join.out (r1.36 -> r1.37)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/join.out?r1=1.36&r2=1.3...)
pgsql/src/test/regress/sql:
join.sql (r1.27 -> r1.28)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/join.sql?r1=1.27&r2=1.28)
^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Repair bug #4926 "too few pathkeys for mergeclauses".
@ 2009-07-17 23:19 Tom Lane <tgl@postgresql.org>
0 siblings, 0 replies; 4+ messages in thread
From: tgl@postgresql.org @ 2009-07-17 23:19 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Repair bug #4926 "too few pathkeys for mergeclauses". This example shows
that the sanity checking I added to create_mergejoin_plan() in 8.3 was a
few bricks shy of a load: the mergeclauses could reference pathkeys in a
noncanonical order such as x,y,x, not only cases like x,x,y which is all
that the code had allowed for. The odd cases only turn up when using
redundant clauses in an outer join condition, which is why no one had
noticed before.
Tags:
----
REL8_4_STABLE
Modified Files:
--------------
pgsql/src/backend/optimizer/path:
pathkeys.c (r1.97 -> r1.97.2.1)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/path/pathkeys.c?r1=1.97&r2=...)
pgsql/src/backend/optimizer/plan:
createplan.c (r1.260 -> r1.260.2.1)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/plan/createplan.c?r1=1.260&...)
pgsql/src/test/regress/expected:
join.out (r1.36 -> r1.36.2.1)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/join.out?r1=1.36&r2=1.3...)
pgsql/src/test/regress/sql:
join.sql (r1.27 -> r1.27.2.1)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/join.sql?r1=1.27&r2=1.27.2.1)
^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Repair bug #4926 "too few pathkeys for mergeclauses".
@ 2009-07-17 23:20 Tom Lane <tgl@postgresql.org>
0 siblings, 0 replies; 4+ messages in thread
From: tgl@postgresql.org @ 2009-07-17 23:20 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Repair bug #4926 "too few pathkeys for mergeclauses". This example shows
that the sanity checking I added to create_mergejoin_plan() in 8.3 was a
few bricks shy of a load: the mergeclauses could reference pathkeys in a
noncanonical order such as x,y,x, not only cases like x,x,y which is all
that the code had allowed for. The odd cases only turn up when using
redundant clauses in an outer join condition, which is why no one had
noticed before.
Tags:
----
REL8_3_STABLE
Modified Files:
--------------
pgsql/src/backend/optimizer/path:
pathkeys.c (r1.93 -> r1.93.2.1)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/path/pathkeys.c?r1=1.93&r2=...)
pgsql/src/backend/optimizer/plan:
createplan.c (r1.237.2.1 -> r1.237.2.2)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/plan/createplan.c?r1=1.237.2.1&...)
pgsql/src/test/regress/expected:
join.out (r1.33.2.1 -> r1.33.2.2)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/join.out?r1=1.33.2.1&r2...)
join_1.out (r1.15.2.1 -> r1.15.2.2)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/join_1.out?r1=1.15.2.1&...)
pgsql/src/test/regress/sql:
join.sql (r1.24.2.1 -> r1.24.2.2)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/join.sql?r1=1.24.2.1&r2=1.24...)
^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Support json_errdetail in FRONTEND code
@ 2024-03-17 23:03 Daniel Gustafsson <dgustafsson@postgresql.org>
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Gustafsson @ 2024-03-17 23:03 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Support json_errdetail in FRONTEND code
Allocate memory for the error message inside memory owned by the
JsonLexContext and move responsibility away from the caller for
freeing it. This means that we can partially revert b44669b2ca
as this is now safe to use in FRONTEND code. The motivation for
this comes from the OAuth and incremental JSON patchsets but it
also adds value on its own.
Author: Jacob Champion <jacob.champion@enterprisedb.com>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/CAOYmi+mWdTd6ujtyF7MsvXvk7ToLRVG_tYAcaGbQLvf=N4KrQw@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d6607016c738a5ccdd9422f3c11778903a03cdbb
Modified Files
--------------
src/bin/pg_verifybackup/t/005_bad_manifest.pl | 3 +-
src/common/jsonapi.c | 121 +++++++++++++++-----------
src/common/parse_manifest.c | 2 +-
src/include/common/jsonapi.h | 1 +
4 files changed, 73 insertions(+), 54 deletions(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2024-03-17 23:03 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-07-17 23:19 pgsql: Repair bug #4926 "too few pathkeys for mergeclauses". Tom Lane <tgl@postgresql.org>
2009-07-17 23:19 pgsql: Repair bug #4926 "too few pathkeys for mergeclauses". Tom Lane <tgl@postgresql.org>
2009-07-17 23:20 pgsql: Repair bug #4926 "too few pathkeys for mergeclauses". Tom Lane <tgl@postgresql.org>
2024-03-17 23:03 pgsql: Support json_errdetail in FRONTEND code Daniel Gustafsson <dgustafsson@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox