pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: tgl@postgresql.org
To: pgsql-committers@postgresql.org
Subject: pgsql: Repair bug #4926 "too few pathkeys for mergeclauses".
Date: Fri, 17 Jul 2009 23:20:15 +0000 (UTC)
Message-ID: <20090717232015.A66A4753336@cvs.postgresql.org> (raw)

Log Message:
-----------
Repair bug #4926 "too few pathkeys for mergeclauses".  This example shows
that the sanity checking I added to create_mergejoin_plan() in 8.3 was a
few bricks shy of a load: the mergeclauses could reference pathkeys in a
noncanonical order such as x,y,x, not only cases like x,x,y which is all
that the code had allowed for.  The odd cases only turn up when using
redundant clauses in an outer join condition, which is why no one had
noticed before.

Tags:
----
REL8_3_STABLE

Modified Files:
--------------
    pgsql/src/backend/optimizer/path:
        pathkeys.c (r1.93 -> r1.93.2.1)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/path/pathkeys.c?r1=1.93&r2=...)
    pgsql/src/backend/optimizer/plan:
        createplan.c (r1.237.2.1 -> r1.237.2.2)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/plan/createplan.c?r1=1.237.2.1&...)
    pgsql/src/test/regress/expected:
        join.out (r1.33.2.1 -> r1.33.2.2)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/join.out?r1=1.33.2.1&r2...)
        join_1.out (r1.15.2.1 -> r1.15.2.2)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/join_1.out?r1=1.15.2.1&...)
    pgsql/src/test/regress/sql:
        join.sql (r1.24.2.1 -> r1.24.2.2)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/join.sql?r1=1.24.2.1&r2=1.24...)




view thread (4+ messages)  latest in thread

Message-ID: <20090717232015.A66A4753336@cvs.postgresql.org>
Permalink:  ../20090717232015.A66A4753336@cvs.postgresql.org/
Also on:    postgresql.org/message-id/20090717232015.A66A4753336@cvs.postgresql.org

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@postgresql.org
  Subject: Re: pgsql: Repair bug #4926 "too few pathkeys for mergeclauses".
  In-Reply-To: <20090717232015.A66A4753336@cvs.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox