pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: Fujii Masao <fujii@postgresql.org>
Cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Mark the second argument of pg_log as the translatable string in
Date: Sat, 11 Apr 2015 22:17:15 -0300
Message-ID: <20150412011715.GK4369@alvh.no-ip.org> (raw)
In-Reply-To: <5529C5A7.3070708@gmx.net>
References: <E1YffOB-0006ry-RI@gemulon.postgresql.org>
	<5529C5A7.3070708@gmx.net>
List-Unsubscribe:  <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>

Peter Eisentraut wrote:
> On 4/7/15 10:06 PM, Fujii Masao wrote:
> > Mark the second argument of pg_log as the translatable string in nls.mk.
> 
> gettext (msgmerge) is unhappy about this because
> 
> po/pg_rewind.pot:501: warning: internationalized messages should not
> contain the '\r' escape sequence

What pg_basebackup's progress_report() does is have the message in the
translatable part not include the \r; the \r is in a separate fprintf()
call.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers



view thread (11+ messages)  latest in thread

Message-ID: <20150412011715.GK4369@alvh.no-ip.org>
Permalink:  ../20150412011715.GK4369@alvh.no-ip.org/
Also on:    postgresql.org/message-id/20150412011715.GK4369@alvh.no-ip.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: alvherre@2ndquadrant.com, peter_e@gmx.net, fujii@postgresql.org
  Subject: Re: pgsql: Mark the second argument of pg_log as the translatable string in
  In-Reply-To: <20150412011715.GK4369@alvh.no-ip.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox