From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Peter Geoghegan <pg@heroku.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE.
Date: Wed, 20 May 2015 19:09:11 -0300
Message-ID: <20150520220911.GK5885@postgresql.org> (raw)
In-Reply-To: <CAM3SWZRUhr1806zsF28CVRrB=b4t8PWv8d9x29z02xTQoFDyWA@mail.gmail.com>
References: <E1YqZCW-0000e6-Od@gemulon.postgresql.org>
<20150520215816.GI5885@postgresql.org>
<CAM3SWZRUhr1806zsF28CVRrB=b4t8PWv8d9x29z02xTQoFDyWA@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Peter Geoghegan wrote:
> On Wed, May 20, 2015 at 2:58 PM, Alvaro Herrera
> <alvherre@2ndquadrant.com> wrote:
> > Hm, I just realized that the command tag for INSERT ON CONFLICT is still
> > just INSERT. Is that okay? To me, the behavior is different enough
> > that it should have its own tag. I'm not too set on this, but maybe
> > others share this opinion?
>
> No it isn't. ON CONFLICT DO UPDATE has an "UPSERT" command tag. DO
> NOTHING has INSERT as its command tag.
... ah ...
> Are you using an old psql? I thought that that would just result in no
> command tag being displayed.
Well, I'm using an editor to read the code of CreateCommandTag(), not
executing anything. I guess that function needs an update, then, no?
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: alvherre@2ndquadrant.com, pg@heroku.com, andres@anarazel.de, pgsql-hackers@postgresql.org
Subject: Re: Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE.
In-Reply-To: <20150520220911.GK5885@postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox