pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Ashutosh Sharma <ashu.coek88@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for extensions are allocated.
Date: Sat, 12 Nov 2016 05:04:08 -0800
Message-ID: <20161112130408.kfsxcbkqo2b3nvuq@alap3.anarazel.de> (raw)
In-Reply-To: <CAA4eK1LJRtV=jBa46F6+=s7cf-x7ajFAraYBdAxaCjZ0m_FQ0w@mail.gmail.com>
References: <E1aRRgI-00022x-UD@gemulon.postgresql.org>
	<20160826220026.2fw6xj56qgd22wqi@alap3.anarazel.de>
	<CA+TgmoYmHD8CdW+8yh6A=i29Co-2xiiH3YBdBRxKFZ8TqP0V8A@mail.gmail.com>
	<CAA4eK1LaN1xXRgo2BxQGLYoXeNaQTZOoFOf6Qi19WfZkknZKgg@mail.gmail.com>
	<20160830023140.tsesenk7roajx3ak@alap3.anarazel.de>
	<CAA4eK1JOjkdXYtHxh=2aDK4VgDtN-LNGKY_YqX0N=YEvuzQVWg@mail.gmail.com>
	<CAA4eK1Jt5fYe2jnQ7XXDrpy3Z4W80UYhQa9SvCyXz+7mcoN8Gw@mail.gmail.com>
	<CAE9k0P=tew0UXETJfM5WQjqNS0k7xYZEFWMZCY8ZuEqRSD1uUA@mail.gmail.com>
	<CAA4eK1LJRtV=jBa46F6+=s7cf-x7ajFAraYBdAxaCjZ0m_FQ0w@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Hi,

On 2016-11-08 10:25:11 +0530, Amit Kapila wrote:
>  ifdef USE_PGXS
>  PG_CONFIG = pg_config
>  PGXS := $(shell $(PG_CONFIG) --pgxs)
> @@ -21,3 +25,29 @@ top_builddir = ../..
>  include $(top_builddir)/src/Makefile.global
>  include $(top_srcdir)/contrib/contrib-global.mk
>  endif
> +
> +# Disabled because these tests require "shared_preload_libraries=pg_stat_statements",
> +# which typical installcheck users do not have (e.g. buildfarm clients).

> +installcheck:;
> +
> +check: regresscheck
> +
> +submake-regress:
> +	$(MAKE) -C $(top_builddir)/src/test/regress all
> +
> +submake-pg_stat_statements:
> +	$(MAKE) -C $(top_builddir)/contrib/pg_stat_statements

Why is this a submake? That seems to make little sense?   But stepping
back one step further: I don't think we need all the remade rules in the
first place.

REGRESS_OPTS = --temp-config $(top_srcdir)/contrib/pg_stat_statements/pg_stat_statements.conf
and then
installcheck: REGRESS=
to prevent installcheck from doing anything ought to be enough these days.

Committed after simplifying the Makefile.

We can't simplify test_decoding's makefile to that extent, because it
uses isolationtester, which we don't provide for contrib yet...

Andres


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (21+ messages)  latest in thread

Message-ID: <20161112130408.kfsxcbkqo2b3nvuq@alap3.anarazel.de>
Permalink:  ../20161112130408.kfsxcbkqo2b3nvuq@alap3.anarazel.de/
Also on:    postgresql.org/message-id/20161112130408.kfsxcbkqo2b3nvuq@alap3.anarazel.de

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, amit.kapila16@gmail.com, ashu.coek88@gmail.com, robertmhaas@gmail.com, pgsql-hackers@postgresql.org
  Subject: Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for extensions are allocated.
  In-Reply-To: <20161112130408.kfsxcbkqo2b3nvuq@alap3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox