From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Dave Page <dpage@postgresql.org>
Cc: pgsql-hackers@postgresql.org, "Tsunakawa, Takayuki" <tsunakawa.takay@jp.fujitsu.com>
Subject: Re: Re: [COMMITTERS] pgsql: Fix and simplify check for whether we're running as Windows serv
Date: Wed, 22 Mar 2017 11:13:05 -0300
Message-ID: <20170322141305.bgxctu22pqnirtgu@alvherre.pgsql> (raw)
In-Reply-To: <ca12b39d-e3da-a270-86c1-43c1d6c9ad5a@iki.fi>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Heikki Linnakangas wrote:
> I did some archeology, and found CheckTokenMembership() in MinGW's w32api
> packages version 3.14
> (https://sourceforge.net/projects/mingw/files/MinGW/Base/w32api/w32api-3.14/,
> in include/winbase.h). According to the timestamps on that download page,
> that was released in 2009. That was the oldest version I could find, so it
> might go even further back.
>
> Dave, do you know exactly what version of MinGW narwhal is running? And how
> difficult is it to upgrade to something slightly more modern? Ease of
> upgrade is another good data point on how far we need to support old
> versions.
Given that this was backpatched and that it broke narwhal in all
branches, I think the solution needs to make narwhal work again without
requiring it to upgrade; so we should acquire CheckTokenMembership via
dynloading just like we do the other functions. If we want to require a
newer mingw version in pg10, that's acceptable, but it should be a
separate patch.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: alvherre@2ndquadrant.com, hlinnaka@iki.fi, tgl@sss.pgh.pa.us, dpage@postgresql.org, tsunakawa.takay@jp.fujitsu.com
Subject: Re: Re: [COMMITTERS] pgsql: Fix and simplify check for whether we're running as Windows serv
In-Reply-To: <20170322141305.bgxctu22pqnirtgu@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox