From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Accept that server might not be able to send error in crash reco
Date: Fri, 22 Sep 2017 10:36:30 -0700
Message-ID: <20170922173630.24hd3y7ratxyuovc@alap3.anarazel.de> (raw)
In-Reply-To: <14968.1506101414@sss.pgh.pa.us>
References: <E1duWps-00030F-Su@gemulon.postgresql.org>
<14968.1506101414@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>
On 2017-09-22 13:30:14 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > Accept that server might not be able to send error in crash recovery test.
>
> piculet says you didn't cover all the bases:
>
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=piculet&dt=2017-09-22%2017%3A10%3A01
>
> Looks like you missed adding the "server closed the connection
> unexpectedly" alternative to one of the three places.
I'd hoped^Wassumed it couldn't happen in that case. I'll expand the
expected output. FWIW, I kinda like the new debugging output for this -
makes it much easier to diagnose.
Besides this individual test, I think we really need to do something
that increases the likelihood of getting these error messages to
clients.
Greetings,
Andres Freund
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, tgl@sss.pgh.pa.us
Subject: Re: pgsql: Accept that server might not be able to send error in crash reco
In-Reply-To: <20170922173630.24hd3y7ratxyuovc@alap3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox