From: Andres Freund <andres@anarazel.de>
To: Simon Riggs <simon@2ndquadrant.com>
Cc: Tomas Vondra <tv@fuzzy.cz>
Cc: pgsql-committers <pgsql-committers@postgresql.org>
Subject: Re: pgsql: Generational memory allocator
Date: Thu, 23 Nov 2017 11:39:36 -0800
Message-ID: <20171123193936.fncfnar5wkpx56mw@alap3.anarazel.de> (raw)
In-Reply-To: <CANP8+jKoT=Pg5W_3FcKiDf+FMrJhFYacxt_g5E0=tkmb5s8M6g@mail.gmail.com>
References: <E1eHa4J-0006hI-Q8@gemulon.postgresql.org>
<20171123001649.y2nf7422iay6cw3v@alap3.anarazel.de>
<CANP8+jKoT=Pg5W_3FcKiDf+FMrJhFYacxt_g5E0=tkmb5s8M6g@mail.gmail.com>
On 2017-11-23 20:57:10 +1100, Simon Riggs wrote:
> On 23 November 2017 at 11:16, Andres Freund <andres@anarazel.de> wrote:
> > Hi,
> >
> > On 2017-11-22 18:48:19 +0000, Simon Riggs wrote:
> >> Generational memory allocator
> >>
> >> Add new style of memory allocator, known as Generational
> >> appropriate for use in cases where memory is allocated
> >> and then freed in roughly oldest first order (FIFO).
> >>
> >> Use new allocator for logical decoding’s reorderbuffer
> >> to significantly reduce memory usage and improve performance.
> >
> > Looks like it's not quite valgrind clean:
> > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2017-11-22%2022%3A30%3A01
>
> It doesn't report anything useful that would allow me to fix this.
Uh. It reports a failure, and you can go from there. The error output
actually is in postmaster.log but for some reason the buildfarm code
didn't display that in this case.
> Please enable some info reporting on the animal.
Hey, I just pointed out for you that there's a problem with something
that you committed. ISTM you're inverting the responsibilities more than
a bit here.
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, simon@2ndquadrant.com, tv@fuzzy.cz
Subject: Re: pgsql: Generational memory allocator
In-Reply-To: <20171123193936.fncfnar5wkpx56mw@alap3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox