From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Emre Hasegeli <emre@hasegeli.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Ning Yu <nyu@pivotal.io>
Cc: pgsql-hackers@postgresql.org
Subject: Re: New Defects reported by Coverity Scan for PostgreSQL
Date: Thu, 15 Nov 2018 12:20:33 -0300
Message-ID: <20181115152033.4m3j2fsxohvahzak@alvherre.pgsql> (raw)
In-Reply-To: <CAE2gYzyYimNSXA67Uqm6pLpqYTVGAMRmLZwrxYrk8=CFsVW5QQ@mail.gmail.com>
On 2018-Nov-06, Emre Hasegeli wrote:
> > Surely the comment in line 3839 deserves an update :-)
>
> Done.
>
> > This seems good material. I would put the detailed conventions comment
> > separately from the head of the file, like this (where I also changed
> > "Type1 *type1" into "Type1 *obj1", and a few "has" to "have")
>
> Looks better to me. I found one more "has" and changed it.
Pushed, with some further minor changes. I decided not to remove the
redundant comments that your patch was removing, as I felt that it's
better to keep the API contract together with the function definition.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: alvherre@2ndquadrant.com, emre@hasegeli.com, tgl@sss.pgh.pa.us, tomas.vondra@2ndquadrant.com, nyu@pivotal.io, pgsql-hackers@postgresql.org
Subject: Re: New Defects reported by Coverity Scan for PostgreSQL
In-Reply-To: <20181115152033.4m3j2fsxohvahzak@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox