pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Update pg_upgrade test for reg* to include regrole and regnamesp
Date: Mon, 26 Nov 2018 22:32:26 -0800
Message-ID: <20181127063226.mpyijg3jwrmmm3rr@alap3.anarazel.de> (raw)
In-Reply-To: <8863.1543297423@sss.pgh.pa.us>
References: <E1gRS1V-0007eS-1p@gemulon.postgresql.org>
	<8863.1543297423@sss.pgh.pa.us>

Hi,

On 2018-11-27 00:43:43 -0500, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > Update pg_upgrade test for reg* to include regrole and regnamespace.
> 
> This has broken all the back-branch cross-version upgrade tests,

Hm, darn it. Gotta rewrite the query to reference those new types
without the regtype casts (as to_regtype without errors doesn't exist
far enough back). Seems easier than having a version check for the
different types.


> to go along with the HEAD cases you already broke :-(

The cross-version bug around pg_largeobject_metadata ought to be fixed
now. I'm hoping for a response by Andrew about the ordering bit, you're
welcome to opine on that too.

I see that prairiedog
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prairiedog&dt=2018-11-27%2005%3A30%3A39
failed just it's last run, but I'm not clear whether that's just a
random failure, or something I can't don't recognize without further
information.

Greetings,

Andres Freund




view thread (11+ messages)  latest in thread

Message-ID: <20181127063226.mpyijg3jwrmmm3rr@alap3.anarazel.de>
Permalink:  ../20181127063226.mpyijg3jwrmmm3rr@alap3.anarazel.de/
Also on:    postgresql.org/message-id/20181127063226.mpyijg3jwrmmm3rr@alap3.anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Update pg_upgrade test for reg* to include regrole and regnamesp
  In-Reply-To: <20181127063226.mpyijg3jwrmmm3rr@alap3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox