From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org, Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Detach constraints when partitions are detached
Date: Thu, 24 Jan 2019 11:28:30 -0300
Message-ID: <201901241428.qggskqa5qwi2@alvherre.pgsql> (raw)
In-Reply-To: <d24d40f3-52d7-296c-8e06-5b153c5ba0dd@lab.ntt.co.jp>
CC'ing -hackers.
On 2019-Jan-24, Amit Langote wrote:
> On 2019/01/24 13:58, Tom Lane wrote:
> > Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> >> Detach constraints when partitions are detached
> >
> > Hm ... it looks like this fails under -DRELCACHE_FORCE_RELEASE:
>
> Oops, sorry. This is why:
>
> index_close(idx, NoLock);
> ...
> + if (!idx->rd_index->indisprimary && !idx->rd_index->indisunique)
> + continue;
>
> Attached a fix.
Mumble. I changed course here and went for simpler coding instead.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: alvherre@2ndquadrant.com, Langote_Amit_f8@lab.ntt.co.jp, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Detach constraints when partitions are detached
In-Reply-To: <201901241428.qggskqa5qwi2@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox