pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Add support for hyperbolic functions, as well as log10().
Date: Wed, 13 Mar 2019 11:21:59 +0900
Message-ID: <20190313022159.GR13812@paquier.xyz> (raw)
In-Reply-To: <E1h3nUY-0000sM-Vf@gemulon.postgresql.org>
References: <E1h3nUY-0000sM-Vf@gemulon.postgresql.org>

On Tue, Mar 12, 2019 at 07:55:14PM +0000, Tom Lane wrote:
> Add support for hyperbolic functions, as well as log10().
> 
> The SQL:2016 standard adds support for the hyperbolic functions
> sinh(), cosh(), and tanh().  POSIX has long required libm to
> provide those functions as well as their inverses asinh(),
> acosh(), atanh().  Hence, let's just expose the libm functions
> to the SQL level.  As with the trig functions, we only implement
> versions for float8, not numeric.

jacana is not a fan of this commit, and failed on float8:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jacana&dt=2019-03-13%2000%3A00%3A27
@@ -476,7 +476,7 @@
SELECT asinh(float8 '0');
 asinh
-------
-     0
+    -0
(1 row)
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../20190313022159.GR13812@paquier.xyz/2-signature.asc)
  download

view thread (20+ messages)  latest in thread

Message-ID: <20190313022159.GR13812@paquier.xyz>
Permalink:  ../20190313022159.GR13812@paquier.xyz/
Also on:    postgresql.org/message-id/20190313022159.GR13812@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
  Subject: Re: pgsql: Add support for hyperbolic functions, as well as log10().
  In-Reply-To: <20190313022159.GR13812@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox