From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter_e@gmx.net>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: Fujii Masao <masao.fujii@gmail.com>
Cc: Fujii Masao <fujii@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.
Date: Tue, 21 May 2019 12:52:09 -0700
Message-ID: <20190521195209.qfzwfxvymguuwlu5@alap3.anarazel.de> (raw)
In-Reply-To: <20190521004717.qsktdsugj3shagco@alap3.anarazel.de>
References: <CAHGQGwEvM9X66Ni4OKv4dOQQddw7z=cNUxnG=wEv84sqj9t_ig@mail.gmail.com>
<20190520163652.l7ibpe52pbq6lecc@alap3.anarazel.de>
<CAHGQGwEixkoMJy4JHUvBdM0MacR1_h=wmE43KTOTErpA2Z5P0w@mail.gmail.com>
<20190520164908.t653bdbfjcn3d35p@alap3.anarazel.de>
<23559.1558374415@sss.pgh.pa.us>
<20190520180027.zyxosts5yrf2i7mh@alap3.anarazel.de>
<24497.1558375780@sss.pgh.pa.us>
<20190520203505.zoeitjlehqypgx26@alap3.anarazel.de>
<21766.1558397960@sss.pgh.pa.us>
<20190521004717.qsktdsugj3shagco@alap3.anarazel.de>
Hi,
On 2019-05-20 17:47:17 -0700, Andres Freund wrote:
> On 2019-05-20 20:19:20 -0400, Tom Lane wrote:
> > Andres Freund <andres@anarazel.de> writes:
> > > On 2019-05-20 14:09:40 -0400, Tom Lane wrote:
> > > 3) The fact that src/bin/pg_upgrade/Makefile invokes test.sh with
> > > MAKE=$(MAKE) triggers make, for reasons I do not yet understand, to
> > > *disable* output synchronization. Which annoys the heck out of me,
> > > because it makes parallel check output neigh unparsable.
> >
> > Probably the same thing as your 2)?
>
> It's not quite. I've not yet fully understood it yet. It's *not* tied to
> MAKEFLAGS. If I understand correctly, when make sees $(MAKE)/${MAKE} in
> a recipe, or the recipe starts with +, it assumes that the sub-command
> is *also* make. And the reason that output synchronization doesn't work
> is that make *intentionally* doesn't enable that for submakes - it only
> wants it for commands run by those submakes (otherwise it could not
> individually output individual targets processed in submakes).
>
> I think the right approach might be to just *never* invoke make inside
> test.sh:
> 1) We can fairly easily fix the make install to be unnecessary
> 2) I think the installcheck-parallel could be replaced by instead
> passing in the the necessary pg_regress command. That'd also have the
> benefit of not having another make invocation stat'ing a lot of files
> etc.
>
> I'll play with these.
1) was easy enough (posted at [1], and also attached here). I think 2)
is a bit harder, because according to src/bin/pg_upgrade/TESTING we
currently support invoking test.sh from commandline.
Therefore I think we ought to just work around that make heuristic, by
referring to $(MAKE) via an indirection. Like in the attached. After
that I don't get any interspersed output anymore if I run with -Otarget.
Greetings,
Andres Freund
[1] https://postgr.es/m/20190521191918.z7kwnrlj45mk2k67%40alap3.anarazel.deAttachments:
v2-0001-pg_upgrade-Don-t-use-separate-installation-for-te.patch (text/x-diff, 0B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, tgl@sss.pgh.pa.us, peter_e@gmx.net, michael.paquier@gmail.com, masao.fujii@gmail.com, fujii@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.
In-Reply-To: <20190521195209.qfzwfxvymguuwlu5@alap3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox