agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Sync our copy of the timezone library with IANA release tzcode20
Date: Fri, 19 Jul 2019 12:53:47 +0900
Message-ID: <20190719035347.GJ1859@paquier.xyz> (raw)
In-Reply-To: <E1hnsNp-0007u8-PD@gemulon.postgresql.org>
References: <E1hnsNp-0007u8-PD@gemulon.postgresql.org>

Hi Tom,
(moving to -hackers)

On Wed, Jul 17, 2019 at 10:26:45PM +0000, Tom Lane wrote:
> Sync our copy of the timezone library with IANA release tzcode2019b.
> 
> A large fraction of this diff is just due to upstream's somewhat
> random decision to rename a bunch of internal variables and struct
> fields.  However, there is an interesting new feature in zic:
> it's grown a "-b slim" option that emits zone files without 32-bit
> data and other backwards-compatibility hacks.  We should consider
> whether we wish to enable that.

This is causing a compilation warning on Windows:
https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=whelk&dt=2019-07-19%2001%3A41%3A13...

"C:\buildfarm\buildenv\HEAD\pgsql.build\pgsql.sln" (Standardziel) (1)
->
"C:\buildfarm\buildenv\HEAD\pgsql.build\zic.vcxproj" (Standardziel)
(72) ->
 src/timezone/zic.c(2401): warning C4804: '-' : unsafe use of type
  'bool' in operation
[C:\buildfarm\buildenv\HEAD\pgsql.build\zic.vcxproj]

Buildfarm members using VS like whelk complains about that, and I can
see the warning myself.
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../20190719035347.GJ1859@paquier.xyz/2-signature.asc)
  download

view thread (104+ messages)  latest in thread

Message-ID: <20190719035347.GJ1859@paquier.xyz>
Permalink:  ../20190719035347.GJ1859@paquier.xyz/
Also on:    postgresql.org/message-id/20190719035347.GJ1859@paquier.xyz

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
  Subject: Re: pgsql: Sync our copy of the timezone library with IANA release tzcode20
  In-Reply-To: <20190719035347.GJ1859@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox