From: Bruce Momjian <bruce@momjian.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: Update copyrights for 2020
Date: Tue, 14 Jan 2020 11:31:09 -0500
Message-ID: <20200114163109.GA10430@momjian.us> (raw)
In-Reply-To: <20200106221523.GA416@alvherre.pgsql>
References: <CA+hUKGKDLjA0qGoVr01TU3+GoHhE40vz7j0+KGjVZF3noLJy0Q@mail.gmail.com>
<20200106221523.GA416@alvherre.pgsql>
On Mon, Jan 6, 2020 at 07:15:23PM -0300, Alvaro Herrera wrote:
> On 2020-Jan-07, Thomas Munro wrote:
>
> > On Fri, Jan 3, 2020 at 7:41 AM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> > > On 2020-Jan-01, Bruce Momjian wrote:
> > > > Update copyrights for 2020
> > > > src/test/ssl/ssl/client-der.key | Bin 1191 -> 1192 bytes
> > > > src/test/ssl/ssl/client-encrypted-der.key | Bin 1191 -> 1192 bytes
> > >
> > > I'm not clear I understand why these two files changed. Did you have to
> > > regenerate them?
> >
> > It looks like Bruce's shell script to advance the hands of time added
> > a newline to these binary files. It didn't seem to break anything,
> > though.
>
> Well, the script does nothing more than run "sed" on the file. It's
> weird that it found matches in those files. Another observation is that
> the script has skip logic for certain binary files; it should skip these
> files too, surely.
>
> (I re-ran the script in the commit prior to Bruce's to verify, and
> indeed it reproduces the changes to those files. Weird.)
I have reverted changes to these *.key files, and updated the copyright
script to avoid *.key files in the future. These files were added in
2019 so this is the first time the copyright file has seen them:
commit 4dc6355210
Author: Andrew Dunstan <andrew@dunslane.net>
Date: Sat Nov 30 15:27:13 2019 -0500
libq support for sslpassword connection param, DER format keys
Thanks for catching this problem.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: bruce@momjian.us, alvherre@2ndquadrant.com, thomas.munro@gmail.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Update copyrights for 2020
In-Reply-To: <20200114163109.GA10430@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox