From: Andres Freund <andres@anarazel.de>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: pgstat: Bring up pgstat in BaseInit() to fix uninitialized use o
Date: Mon, 9 Aug 2021 10:34:53 -0700
Message-ID: <20210809173453.6fugm2z7k6uaztld@alap3.anarazel.de> (raw)
In-Reply-To: <CA+TgmoZWP6njzr3zTuB0rHeVL7+z0hdaU+-gj0vcZHHghyyiLA@mail.gmail.com>
References: <E1mCC6U-0004Ik-Fs@gemulon.postgresql.org>
<2638683.1628304247@sss.pgh.pa.us>
<20210807030652.qf5wsbhxk7dpsmtn@alap3.anarazel.de>
<2640064.1628306008@sss.pgh.pa.us>
<2640490.1628306556@sss.pgh.pa.us>
<20210807044952.orwuf7hua2wytx4g@alap3.anarazel.de>
<20210807051149.x2j3n64ejcu23hm4@alap3.anarazel.de>
<2675112.1628350987@sss.pgh.pa.us>
<CA+TgmoZWP6njzr3zTuB0rHeVL7+z0hdaU+-gj0vcZHHghyyiLA@mail.gmail.com>
Hi,
On 2021-08-09 11:46:30 -0400, Robert Haas wrote:
> I think that subsystems like "memory" and "files" really ought to be
> the lowest-level things we have, and should be shut down last.
I don't disagree with that - but there's a difference between having that as
an abstract goal, and having it a dependency of committing somebodies patch.
> Stuff like "send a message to the stats collector" seems like a higher level
> thing that may require those lower-level facilities in order to operate, and
> must therefore be shut down first.
Yep.
> Maybe some subsystems need to be divided into upper and lower levels to make
> this work, or, well, I don't know, something else.
That's what I ended up doing, right? There's now InitFileAccess() and
InitTemporaryFileAccess().
> But I'm deeply suspicious that lifting stuff like this to the front of the
> shutdown sequence is just papering over the problem, and not actually
> solving it.
If you have a concrete proposal that you think makes sense to tie shared
memory stats to, I'm happy to entertain it. One main motivator for b406478b87e
etc was to allow rejiggering things like this more easily.
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, robertmhaas@gmail.com, tgl@sss.pgh.pa.us
Subject: Re: pgsql: pgstat: Bring up pgstat in BaseInit() to fix uninitialized use o
In-Reply-To: <20210809173453.6fugm2z7k6uaztld@alap3.anarazel.de>
References: <E1mCC6U-0004Ik-Fs@gemulon.postgresql.org> <2638683.1628304247@sss.pgh.pa.us> <20210807030652.qf5wsbhxk7dpsmtn@alap3.anarazel.de> <2640064.1628306008@sss.pgh.pa.us> <2640490.1628306556@sss.pgh.pa.us> <20210807044952.orwuf7hua2wytx4g@alap3.anarazel.de> <20210807051149.x2j3n64ejcu23hm4@alap3.anarazel.de> <2675112.1628350987@sss.pgh.pa.us> <CA+TgmoZWP6njzr3zTuB0rHeVL7+z0hdaU+-gj0vcZHHghyyiLA@mail.gmail.com> <20210809173453.6fugm2z7k6uaztld@alap3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox