pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Update high level vacuumlazy.c comments.
7+ messages / 3 participants
[nested] [flat]
* pgsql: Update high level vacuumlazy.c comments.
@ 2021-11-27 22:31 Peter Geoghegan <pg@bowt.ie>
0 siblings, 1 reply; 7+ messages in thread
From: Peter Geoghegan @ 2021-11-27 22:31 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Update high level vacuumlazy.c comments.
Update vacuumlazy.c file header comments (as well as comments above the
lazy_scan_heap function) that were largely written before the
introduction of the HOT optimization, when lazy_scan_heap did far less,
and didn't actually prune during its initial heap pass.
Since lazy_scan_heap now outsources far more work to lower level
functions, it makes sense to introduce the function by talking about the
high level invariant that dictates the order in which each phase takes
place. Also deemphasize the case where we run out of memory for TIDs,
since delaying that discussion makes it easier to talk about issues of
central importance.
Finally, remove discussion of parallel VACUUM from header comments.
These don't add much, and are in the wrong place.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/12b5ade9023f3ecaddcbc423a22dc284c91c79f6
Modified Files
--------------
src/backend/access/heap/vacuumlazy.c | 138 ++++++++++++++++++-----------------
1 file changed, 70 insertions(+), 68 deletions(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: pgsql: Update high level vacuumlazy.c comments.
@ 2021-11-29 14:58 Robert Haas <robertmhaas@gmail.com>
parent: Peter Geoghegan <pg@bowt.ie>
0 siblings, 1 reply; 7+ messages in thread
From: Robert Haas @ 2021-11-29 14:58 UTC (permalink / raw)
To: Peter Geoghegan <pg@bowt.ie>; +Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
On Sat, Nov 27, 2021 at 5:31 PM Peter Geoghegan <pg@bowt.ie> wrote:
> Update high level vacuumlazy.c comments.
>
> Update vacuumlazy.c file header comments (as well as comments above the
> lazy_scan_heap function) that were largely written before the
> introduction of the HOT optimization, when lazy_scan_heap did far less,
> and didn't actually prune during its initial heap pass.
>
> Since lazy_scan_heap now outsources far more work to lower level
> functions, it makes sense to introduce the function by talking about the
> high level invariant that dictates the order in which each phase takes
> place. Also deemphasize the case where we run out of memory for TIDs,
> since delaying that discussion makes it easier to talk about issues of
> central importance.
>
> Finally, remove discussion of parallel VACUUM from header comments.
> These don't add much, and are in the wrong place.
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/12b5ade9023f3ecaddcbc423a22dc284c91c79f6
I don't know whether this was discussed and you forgot to include a
Discussion link, or whether it wasn't discussed on list, but typically
both things should happen.
--
Robert Haas
EDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: pgsql: Update high level vacuumlazy.c comments.
@ 2021-11-29 16:40 Peter Geoghegan <pg@bowt.ie>
parent: Robert Haas <robertmhaas@gmail.com>
0 siblings, 1 reply; 7+ messages in thread
From: Peter Geoghegan @ 2021-11-29 16:40 UTC (permalink / raw)
To: Robert Haas <robertmhaas@gmail.com>; +Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
On Mon, Nov 29, 2021 at 6:58 AM Robert Haas <robertmhaas@gmail.com> wrote:
> I don't know whether this was discussed and you forgot to include a
> Discussion link, or whether it wasn't discussed on list, but typically
> both things should happen.
This was a piece of the patch I posted here, which was discussed in
general terms:
https://postgr.es/m/CAH2-WzktGBg4si6DEdmq3q6SoXSDqNi6MtmB8CmmTmvhsxDTLA@mail.gmail.com
I found it useful to spin off the parts that reworked the high level
comments, which aren't really related to the main point of discussion
in the thread. I think that I didn't supply a link for that reason.
--
Peter Geoghegan
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: pgsql: Update high level vacuumlazy.c comments.
@ 2021-11-30 14:41 Alvaro Herrera <alvherre@alvh.no-ip.org>
parent: Peter Geoghegan <pg@bowt.ie>
0 siblings, 1 reply; 7+ messages in thread
From: Alvaro Herrera @ 2021-11-30 14:41 UTC (permalink / raw)
To: Peter Geoghegan <pg@bowt.ie>; +Cc: Robert Haas <robertmhaas@gmail.com>; pgsql-committers <pgsql-committers@lists.postgresql.org>
On 2021-Nov-29, Peter Geoghegan wrote:
> This was a piece of the patch I posted here, which was discussed in
> general terms:
>
> https://postgr.es/m/CAH2-WzktGBg4si6DEdmq3q6SoXSDqNi6MtmB8CmmTmvhsxDTLA@mail.gmail.com
>
> I found it useful to spin off the parts that reworked the high level
> comments, which aren't really related to the main point of discussion
> in the thread. I think that I didn't supply a link for that reason.
I think the only reason not to include a discussion link in the commit
message is that the patch is so trivial that there *is* no related post
in the mailing list.
--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
Are you not unsure you want to delete Firefox?
[Not unsure] [Not not unsure] [Cancel]
http://smylers.hates-software.com/2008/01/03/566e45b2.html
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: pgsql: Update high level vacuumlazy.c comments.
@ 2021-11-30 20:20 Robert Haas <robertmhaas@gmail.com>
parent: Alvaro Herrera <alvherre@alvh.no-ip.org>
0 siblings, 1 reply; 7+ messages in thread
From: Robert Haas @ 2021-11-30 20:20 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@alvh.no-ip.org>; +Cc: Peter Geoghegan <pg@bowt.ie>; pgsql-committers <pgsql-committers@lists.postgresql.org>
On Tue, Nov 30, 2021 at 9:41 AM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> I think the only reason not to include a discussion link in the commit
> message is that the patch is so trivial that there *is* no related post
> in the mailing list.
+1. And that shouldn't happen often.
--
Robert Haas
EDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: pgsql: Update high level vacuumlazy.c comments.
@ 2021-11-30 20:44 Peter Geoghegan <pg@bowt.ie>
parent: Robert Haas <robertmhaas@gmail.com>
0 siblings, 1 reply; 7+ messages in thread
From: Peter Geoghegan @ 2021-11-30 20:44 UTC (permalink / raw)
To: Robert Haas <robertmhaas@gmail.com>; +Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>; pgsql-committers <pgsql-committers@lists.postgresql.org>
On Tue, Nov 30, 2021 at 12:20 PM Robert Haas <robertmhaas@gmail.com> wrote:
> +1. And that shouldn't happen often.
Why shouldn't it happen often?
I accept that I ought to have included a discussion link in this
instance. But I don't see how that's related to how often I commit
things where including a discussion link is unnecessary (per the
general convention for these things).
--
Peter Geoghegan
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: pgsql: Update high level vacuumlazy.c comments.
@ 2021-12-01 14:16 Robert Haas <robertmhaas@gmail.com>
parent: Peter Geoghegan <pg@bowt.ie>
0 siblings, 0 replies; 7+ messages in thread
From: Robert Haas @ 2021-12-01 14:16 UTC (permalink / raw)
To: Peter Geoghegan <pg@bowt.ie>; +Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>; pgsql-committers <pgsql-committers@lists.postgresql.org>
On Tue, Nov 30, 2021 at 3:45 PM Peter Geoghegan <pg@bowt.ie> wrote:
> On Tue, Nov 30, 2021 at 12:20 PM Robert Haas <robertmhaas@gmail.com> wrote:
> > +1. And that shouldn't happen often.
>
> Why shouldn't it happen often?
>
> I accept that I ought to have included a discussion link in this
> instance. But I don't see how that's related to how often I commit
> things where including a discussion link is unnecessary (per the
> general convention for these things).
Because there aren't many things that are so mechanical that there's
no reason to give people an opportunity to comment. Sure, if you're
just changing "teh" to "the" that's boring and there's nothing to talk
about. But if you're doing that every day, you should consolidate your
typo fix patches a bit so we don't clutter the commit history. If
you're making changes that people might disagree with, it's polite to
give them an opportunity to object before you commit. Even if most of
the time they don't.
--
Robert Haas
EDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2021-12-01 14:16 UTC | newest]
Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-11-27 22:31 pgsql: Update high level vacuumlazy.c comments. Peter Geoghegan <pg@bowt.ie>
2021-11-29 14:58 ` Robert Haas <robertmhaas@gmail.com>
2021-11-29 16:40 ` Peter Geoghegan <pg@bowt.ie>
2021-11-30 14:41 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-11-30 20:20 ` Robert Haas <robertmhaas@gmail.com>
2021-11-30 20:44 ` Peter Geoghegan <pg@bowt.ie>
2021-12-01 14:16 ` Robert Haas <robertmhaas@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox