pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Geoghegan <pg@bowt.ie>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Update high level vacuumlazy.c comments.
Date: Sat, 27 Nov 2021 22:31:24 +0000
Message-ID: <E1mr6E8-0000x1-SN@gemulon.postgresql.org> (raw)

Update high level vacuumlazy.c comments.

Update vacuumlazy.c file header comments (as well as comments above the
lazy_scan_heap function) that were largely written before the
introduction of the HOT optimization, when lazy_scan_heap did far less,
and didn't actually prune during its initial heap pass.

Since lazy_scan_heap now outsources far more work to lower level
functions, it makes sense to introduce the function by talking about the
high level invariant that dictates the order in which each phase takes
place.  Also deemphasize the case where we run out of memory for TIDs,
since delaying that discussion makes it easier to talk about issues of
central importance.

Finally, remove discussion of parallel VACUUM from header comments.
These don't add much, and are in the wrong place.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/12b5ade9023f3ecaddcbc423a22dc284c91c79f6

Modified Files
--------------
src/backend/access/heap/vacuumlazy.c | 138 ++++++++++++++++++-----------------
1 file changed, 70 insertions(+), 68 deletions(-)



view thread (7+ messages)  latest in thread

Message-ID: <E1mr6E8-0000x1-SN@gemulon.postgresql.org>
Permalink:  ../E1mr6E8-0000x1-SN@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mr6E8-0000x1-SN@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: pg@bowt.ie
  Subject: Re: pgsql: Update high level vacuumlazy.c comments.
  In-Reply-To: <E1mr6E8-0000x1-SN@gemulon.postgresql.org>
  References: <E1mr6E8-0000x1-SN@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox