From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Revoke PUBLIC CREATE from public schema, now owned by pg_databas
Date: Fri, 17 Dec 2021 10:25:18 -0800
Message-ID: <20211217182518.GA2529654@rfd.leadboat.com> (raw)
In-Reply-To: <1363170.1639763559@sss.pgh.pa.us>
References: <E1mOaBy-0006mH-1P@gemulon.postgresql.org>
<1363170.1639763559@sss.pgh.pa.us>
On Fri, Dec 17, 2021 at 12:52:39PM -0500, Tom Lane wrote:
> Noah Misch <noah@leadboat.com> writes:
> > Revoke PUBLIC CREATE from public schema, now owned by pg_database_owner.
>
> I've just stumbled across a testing problem created by this commit:
> if you try to skip the tablespace test, the rest of the run falls
> over, because this bit doesn't get executed:
>
> -- Rest of this suite can use the public schema freely.
> GRANT ALL ON SCHEMA public TO public;
>
> Skipping the tablespace test is something I've been accustomed to do
> when testing replication with the standby on the same machine as the
> primary, because otherwise you've got to fool with keeping the
> standby from overwriting the primary's tablespaces. This hack made
> that a lot more painful.
>
> I'm inclined to think the cleanest fix is to move this step into a
> new script, say "test_setup.sql", that is scheduled by itself just
> after tablespace.sql.
I like that solution for your use case.
> It's sort of annoying to fire up a psql+backend
> for just one command, but perhaps there's other stuff that could be
> put there too.
Yes. The src/test/regress suite would be in a better place if one could run
most test files via a schedule containing only two files, the setup file and
the file of interest. Adding things like the "CREATE TABLE tenk1" to the
setup file would help that.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: noah@leadboat.com, tgl@sss.pgh.pa.us
Subject: Re: pgsql: Revoke PUBLIC CREATE from public schema, now owned by pg_databas
In-Reply-To: <20211217182518.GA2529654@rfd.leadboat.com>
References: <E1mOaBy-0006mH-1P@gemulon.postgresql.org> <1363170.1639763559@sss.pgh.pa.us> <20211217182518.GA2529654@rfd.leadboat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox