pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>
To: pgsql-hackers@postgresql.org
To: pgsql-release@postgresql.org
Cc: Noah Misch <noah@leadboat.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURR
Date: Tue, 8 Feb 2022 16:43:47 -0800
Message-ID: <20220209004347.mnwaoiv5x7dntuvi@alap3.anarazel.de> (raw)
In-Reply-To: <df7b4c0b-7d92-f03f-75c4-9e08b269a716@enterprisedb.com>
References: <E1meSUe-0004WX-H2@gemulon.postgresql.org>
	<df7b4c0b-7d92-f03f-75c4-9e08b269a716@enterprisedb.com>

Hi,

On 2022-02-08 22:13:01 +0100, Tomas Vondra wrote:
> On 10/24/21 03:40, Noah Misch wrote:
> > Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURRENTLY.
> > 
> > CIC and REINDEX CONCURRENTLY assume backends see their catalog changes
> > no later than each backend's next transaction start.  That failed to
> > hold when a backend absorbed a relevant invalidation in the middle of
> > running RelationBuildDesc() on the CIC index.  Queries that use the
> > resulting index can silently fail to find rows.  Fix this for future
> > index builds by making RelationBuildDesc() loop until it finishes
> > without accepting a relevant invalidation.  It may be necessary to
> > reindex to recover from past occurrences; REINDEX CONCURRENTLY suffices.
> > Back-patch to 9.6 (all supported versions).
> > 
> > Noah Misch and Andrey Borodin, reviewed (in earlier versions) by Andres
> > Freund.
> > 
> > Discussion: https://postgr.es/m/20210730022548.GA1940096@gust.leadboat.com
> > 
> 
> Unfortunately, this seems to have broken CLOBBER_CACHE_ALWAYS builds. Since
> this commit, initdb never completes due to infinite retrying over and over
> (on the first RelationBuildDesc call).

Ugh. Do we need to do something about WRT the next set of minor releases? Is
there a a chance of this occuring in "real" workloads?

Greetings,

Andres Freund





view thread (18+ messages)  latest in thread

Message-ID: <20220209004347.mnwaoiv5x7dntuvi@alap3.anarazel.de>
Permalink:  ../20220209004347.mnwaoiv5x7dntuvi@alap3.anarazel.de/
Also on:    postgresql.org/message-id/20220209004347.mnwaoiv5x7dntuvi@alap3.anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, tomas.vondra@enterprisedb.com, pgsql-hackers@postgresql.org, pgsql-release@postgresql.org, noah@leadboat.com
  Subject: Re: pgsql: Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURR
  In-Reply-To: <20220209004347.mnwaoiv5x7dntuvi@alap3.anarazel.de>
  References: <E1meSUe-0004WX-H2@gemulon.postgresql.org> <df7b4c0b-7d92-f03f-75c4-9e08b269a716@enterprisedb.com> <20220209004347.mnwaoiv5x7dntuvi@alap3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox