From: Justin Pryzby <pryzby@telsasoft.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Allow extensions to add new backup targets.
Date: Wed, 16 Mar 2022 10:08:12 -0500
Message-ID: <20220316150812.GA28503@telsasoft.com> (raw)
In-Reply-To: <CA+TgmoY33KQy61JQREnnxKHnyiVnnarGQUFZqAhvbBdXSBMCqQ@mail.gmail.com>
References: <E1nUB2m-000CYC-D5@gemulon.postgresql.org>
<YjGvq4zPDT6j15go@paquier.xyz>
<CA+TgmoY33KQy61JQREnnxKHnyiVnnarGQUFZqAhvbBdXSBMCqQ@mail.gmail.com>
On Wed, Mar 16, 2022 at 09:52:41AM -0400, Robert Haas wrote:
> On Wed, Mar 16, 2022 at 5:36 AM Michael Paquier <michael@paquier.xyz> wrote:
> > I have noticed that this commit produces a warning when building with
> > MSVC, as of the end of BaseBackupGetTargetHandle() when the target
> > cannot be found. I guess that you'd better add a fake return NULL to
> > keep such compilers quiet about that, like that:
> > +++ b/src/backend/replication/basebackup_target.c
> > @@ -144,6 +144,9 @@ BaseBackupGetTargetHandle(char *target, char *target_detail)
> > ereport(ERROR,
> > (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
> > errmsg("unrecognized target: \"%s\"", target)));
> > +
> > + /* keep compiler quiet */
> > + return NULL;
> > }
>
> Done.
>
> It sucks that I keep missing this point. And it also sucks that we
> have to have this kind of stuff. :-(
FYI - at some point, CI will catch these in advance, per Andres' suggestion on
the big "basebackup" thread.
https://github.com/justinpryzby/postgres/commit/451e522a26f2b9a62976834ef7848279514ca700
--
Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: pryzby@telsasoft.com, robertmhaas@gmail.com, michael@paquier.xyz
Subject: Re: pgsql: Allow extensions to add new backup targets.
In-Reply-To: <20220316150812.GA28503@telsasoft.com>
References: <E1nUB2m-000CYC-D5@gemulon.postgresql.org> <YjGvq4zPDT6j15go@paquier.xyz> <CA+TgmoY33KQy61JQREnnxKHnyiVnnarGQUFZqAhvbBdXSBMCqQ@mail.gmail.com> <20220316150812.GA28503@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox