From: Andres Freund <andres@anarazel.de>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: pgsql-committers@lists.postgresql.org, Michael Paquier <michael@paquier.xyz>
Subject: Re: pgsql: Add function to pump IPC process until string match
Date: Wed, 30 Mar 2022 09:09:16 -0700
Message-ID: <20220330160916.vpsxtjss25yfyq3p@alap3.anarazel.de> (raw)
In-Reply-To: <E79F5248-24C2-4F48-8E10-DC592A588D79@yesql.se>
References: <E1nMrkR-000Hoa-VF@gemulon.postgresql.org>
<20220329225819.ahk5u2tax3ez6d2t@alap3.anarazel.de>
<E79F5248-24C2-4F48-8E10-DC592A588D79@yesql.se>
Hi,
On 2022-03-30 09:10:17 +0200, Daniel Gustafsson wrote:
> > On 30 Mar 2022, at 00:58, Andres Freund <andres@anarazel.de> wrote:
> > On 2022-02-23 13:32:03 +0000, Daniel Gustafsson wrote:
>
> >> Add function to pump IPC process until string match
> >>
> >> Refactor the recovery tests to not carry a local duplicated copy of
> >> the pump_until function which pumps a process until a defined string
> >> is seen on a stream. This reduces duplication, and is in preparation
> >> for another patch which will also use this functionality.
> >
> > I'm a bit disappointed by the moved function not having the diagnostic output
> > that at least the version in 013_crash_restart.pl had. How is one supposed to
> > figure out what caused a timeout with the new central version?
>
> Thats my bad then. Since we don't really have diag output in any module I was
> going off that "precedent" when moving this over.
We have a few places that manually output diagnostic stuff by printing with #
etc.
> > Given that timeouts are the only way tests using pump_until() fail, that's not
> > great.
>
> They can also fail on the pumped process crashing/exiting before the timeout
> without emitting the expected output.
Fair.
> Would adding back something like the (right now untested) below be what you're
> after? Looking at the perldoc I didn't see any other debugging aids we can
> emit other than the stream and type of error.
I found showing the regex from before useful. Often there's many
pump_until()'s, and the regex makes it easier to figure out what errored
out. And it shows quoting problem. Since it only happens when there was a
failure, it's not like it'll bloat the log unduly.
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, daniel@yesql.se, michael@paquier.xyz
Subject: Re: pgsql: Add function to pump IPC process until string match
In-Reply-To: <20220330160916.vpsxtjss25yfyq3p@alap3.anarazel.de>
References: <E1nMrkR-000Hoa-VF@gemulon.postgresql.org> <20220329225819.ahk5u2tax3ez6d2t@alap3.anarazel.de> <E79F5248-24C2-4F48-8E10-DC592A588D79@yesql.se> <20220330160916.vpsxtjss25yfyq3p@alap3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox