From: Andres Freund <andres@anarazel.de>
To: John Naylor <john.naylor@enterprisedb.com>
Cc: John Naylor <john.naylor@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Specialize tuplesort routines for different kinds of abbreviated
Date: Sat, 2 Apr 2022 13:33:44 -0700
Message-ID: <20220402203344.ahup2u5n73cdbbcv@alap3.anarazel.de> (raw)
In-Reply-To: <20220402201557.thanbsxcql5lk6pc@alap3.anarazel.de>
References: <E1naZ8x-000QbH-D0@gemulon.postgresql.org>
<CAFBsxsFLcJFBTniD1=4qYNUkqVsnxuS870s6_GOp3R-Tg8rg0Q@mail.gmail.com>
<20220402201557.thanbsxcql5lk6pc@alap3.anarazel.de>
Hi,
On 2022-04-02 13:15:57 -0700, Andres Freund wrote:
> There's definitely something borked - looks like this is ending up with bogus
> pointers? Using rr to set a watchpoint on isnull1, and continuing backward I
> see the memory written to with the following stack:
Looks like it's just plain old uninitialized data. tuplesort_putheaptuple()
doesn't compute SortTuple.{isnull1,datum1}. And comparetup_heap() doesn't rely
on them being set. But tuplesort_sort_memtuples() will now bypass
comparetup_heap(), so comparetup_heap computing those doesn't help anymore.
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, john.naylor@enterprisedb.com, john.naylor@postgresql.org
Subject: Re: pgsql: Specialize tuplesort routines for different kinds of abbreviated
In-Reply-To: <20220402203344.ahup2u5n73cdbbcv@alap3.anarazel.de>
References: <E1naZ8x-000QbH-D0@gemulon.postgresql.org> <CAFBsxsFLcJFBTniD1=4qYNUkqVsnxuS870s6_GOp3R-Tg8rg0Q@mail.gmail.com> <20220402201557.thanbsxcql5lk6pc@alap3.anarazel.de> <20220402203344.ahup2u5n73cdbbcv@alap3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox