pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: pgstat: add pg_stat_force_next_flush(), use it to simplify tests
3+ messages / 2 participants
[nested] [flat]
* pgsql: pgstat: add pg_stat_force_next_flush(), use it to simplify tests
@ 2022-04-07 06:39 Andres Freund <andres@anarazel.de>
2022-04-07 07:01 ` Re: pgsql: pgstat: add pg_stat_force_next_flush(), use it to simplify tests John Naylor <john.naylor@enterprisedb.com>
0 siblings, 1 reply; 3+ messages in thread
From: Andres Freund @ 2022-04-07 06:39 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
pgstat: add pg_stat_force_next_flush(), use it to simplify tests.
In the stats collector days it was hard to write tests for the stats system,
because fundamentally delivery of stats messages over UDP was not
synchronous (nor guaranteed). Now we easily can force pending stats updates to
be flushed synchronously.
This moves stats.sql into a parallel group, there isn't a reason for it to run
in isolation anymore. And it may shake out some bugs.
Bumps catversion.
Author: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/20220303021600.hs34ghqcw6zcokdh@alap3.anarazel.de
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/0f96965c658147d6d6bad096d2d4a2c9c665f4a9
Modified Files
--------------
contrib/test_decoding/expected/stats.out | 71 +++---------------
contrib/test_decoding/sql/stats.sql | 59 ++-------------
src/backend/utils/activity/pgstat.c | 23 ++++++
src/backend/utils/adt/pgstatfuncs.c | 10 +++
src/include/catalog/pg_proc.dat | 5 ++
src/include/pgstat.h | 1 +
src/test/regress/expected/brin.out | 22 ++++++
src/test/regress/expected/stats.out | 123 +------------------------------
src/test/regress/parallel_schedule | 5 +-
src/test/regress/sql/brin.sql | 19 +++++
src/test/regress/sql/stats.sql | 119 +-----------------------------
11 files changed, 103 insertions(+), 354 deletions(-)
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: pgstat: add pg_stat_force_next_flush(), use it to simplify tests
2022-04-07 06:39 pgsql: pgstat: add pg_stat_force_next_flush(), use it to simplify tests Andres Freund <andres@anarazel.de>
@ 2022-04-07 07:01 ` John Naylor <john.naylor@enterprisedb.com>
2022-04-07 07:11 ` Re: pgsql: pgstat: add pg_stat_force_next_flush(), use it to simplify tests Andres Freund <andres@anarazel.de>
0 siblings, 1 reply; 3+ messages in thread
From: John Naylor @ 2022-04-07 07:01 UTC (permalink / raw)
To: Andres Freund <andres@anarazel.de>; +Cc: pgsql-committers@lists.postgresql.org
On Thu, Apr 7, 2022 at 1:40 PM Andres Freund <andres@anarazel.de> wrote:
> Bumps catversion.
Looks like this part didn't make it.
--
John Naylor
EDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: pgstat: add pg_stat_force_next_flush(), use it to simplify tests
2022-04-07 06:39 pgsql: pgstat: add pg_stat_force_next_flush(), use it to simplify tests Andres Freund <andres@anarazel.de>
2022-04-07 07:01 ` Re: pgsql: pgstat: add pg_stat_force_next_flush(), use it to simplify tests John Naylor <john.naylor@enterprisedb.com>
@ 2022-04-07 07:11 ` Andres Freund <andres@anarazel.de>
0 siblings, 0 replies; 3+ messages in thread
From: Andres Freund @ 2022-04-07 07:11 UTC (permalink / raw)
To: John Naylor <john.naylor@enterprisedb.com>; +Cc: pgsql-committers@lists.postgresql.org
Hi,
On 2022-04-07 14:01:14 +0700, John Naylor wrote:
> On Thu, Apr 7, 2022 at 1:40 PM Andres Freund <andres@anarazel.de> wrote:
> > Bumps catversion.
>
> Looks like this part didn't make it.
Damn. I think it was automatically resolved away by git when rebasing, because
5c279a6d350 contained the same change. git reflog shows that the commit ontop
of a8cfb0c1a96 still had it. Then I rebased onto 5c279a6d350 and it was gone.
I have another commit with a catversion bump queued up, so that'll take care
of that.
Greetings,
Andres Freund
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2022-04-07 07:11 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-04-07 06:39 pgsql: pgstat: add pg_stat_force_next_flush(), use it to simplify tests Andres Freund <andres@anarazel.de>
2022-04-07 07:01 ` John Naylor <john.naylor@enterprisedb.com>
2022-04-07 07:11 ` Andres Freund <andres@anarazel.de>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox