pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pgstat: add pg_stat_force_next_flush(), use it to simplify tests
Date: Thu, 07 Apr 2022 06:39:53 +0000
Message-ID: <E1ncLo9-000hDA-2L@gemulon.postgresql.org> (raw)

pgstat: add pg_stat_force_next_flush(), use it to simplify tests.

In the stats collector days it was hard to write tests for the stats system,
because fundamentally delivery of stats messages over UDP was not
synchronous (nor guaranteed). Now we easily can force pending stats updates to
be flushed synchronously.

This moves stats.sql into a parallel group, there isn't a reason for it to run
in isolation anymore. And it may shake out some bugs.

Bumps catversion.

Author: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/20220303021600.hs34ghqcw6zcokdh@alap3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0f96965c658147d6d6bad096d2d4a2c9c665f4a9

Modified Files
--------------
contrib/test_decoding/expected/stats.out |  71 +++---------------
contrib/test_decoding/sql/stats.sql      |  59 ++-------------
src/backend/utils/activity/pgstat.c      |  23 ++++++
src/backend/utils/adt/pgstatfuncs.c      |  10 +++
src/include/catalog/pg_proc.dat          |   5 ++
src/include/pgstat.h                     |   1 +
src/test/regress/expected/brin.out       |  22 ++++++
src/test/regress/expected/stats.out      | 123 +------------------------------
src/test/regress/parallel_schedule       |   5 +-
src/test/regress/sql/brin.sql            |  19 +++++
src/test/regress/sql/stats.sql           | 119 +-----------------------------
11 files changed, 103 insertions(+), 354 deletions(-)



view thread (3+ messages)  latest in thread

Message-ID: <E1ncLo9-000hDA-2L@gemulon.postgresql.org>
Permalink:  ../E1ncLo9-000hDA-2L@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1ncLo9-000hDA-2L@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de
  Subject: Re: pgsql: pgstat: add pg_stat_force_next_flush(), use it to simplify tests
  In-Reply-To: <E1ncLo9-000hDA-2L@gemulon.postgresql.org>
  References: <E1ncLo9-000hDA-2L@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox