From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org, Andrew Dunstan <andrew@dunslane.net>
Subject: Re: pgsql: ecpg: Output dir, source dir, stamp file argument for preproc/*.
Date: Mon, 18 Jul 2022 15:15:35 -0700
Message-ID: <20220718221535.bf43zwf5rf2wi4wd@awork3.anarazel.de> (raw)
In-Reply-To: <838180.1658181982@sss.pgh.pa.us>
References: <E1oDWqn-000ADD-Oh@gemulon.postgresql.org>
<20220718211408.o2uyu5kvud56ihlj@awork3.anarazel.de>
<822625.1658179641@sss.pgh.pa.us>
<20220718215042.sl3hivoupdb7lkwv@awork3.anarazel.de>
<838180.1658181982@sss.pgh.pa.us>
Hi,
On 2022-07-18 18:06:22 -0400, Tom Lane wrote:
> While looking at this, I wondered if parse.pl's handy-dandy little exception
>
> no warnings 'uninitialized';
>
> might be related to the issue. Evidently it's not, but now that
> I've noticed it I definitely think it's not up to project standard.
Yea, that doesn't seem great.
> I took it out and fixed the half-dozen places where I got warnings,
> as attached.
Grepping for 'no warnings' shows that check_rules.pl has the same
issue. Perhaps worth fixing at the same time, given how closely related they
are?
> Seem like a good fix?
Looks good to my not-perl-trained eyes.
Might be worth making sure the output files are the same before / after? You
probably already checked...
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, tgl@sss.pgh.pa.us, andrew@dunslane.net
Subject: Re: pgsql: ecpg: Output dir, source dir, stamp file argument for preproc/*.
In-Reply-To: <20220718221535.bf43zwf5rf2wi4wd@awork3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox