From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Amit Kapila <akapila@postgresql.org>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP.
Date: Sun, 4 Sep 2022 10:18:21 +0200
Message-ID: <20220904081821.bck6q2j6gfp3p2im@alvherre.pgsql> (raw)
In-Reply-To: <E1nWTkh-000ncF-2O@gemulon.postgresql.org>
On 2022-Mar-22, Amit Kapila wrote:
> Add ALTER SUBSCRIPTION ... SKIP.
There are two messages here that seem oddly worded.
msgid "start skipping logical replication transaction finished at %X/%X"
msgid "done skipping logical replication transaction finished at %X/%X"
Two complaints here. First, the phrases "start / finished" and "done /
finished" look very strange. It took me a while to realize that
"finished" refers to the LSN, not to the skipping operation. Do we ever
talk about a transaction "finished at XYZ" as opposed to a transaction
whose LSN is XYZ? (This became particularly strange when I realized
that the LSN might come from a PREPARE.)
Second, "logical replication transaction". Is it not a regular
transaction that we happen to be processing via logical replication?
I think they should say something like
"logical replication starts skipping transaction with LSN %X/%X"
"logical replication completed skipping transaction with LSN %X/%X"
Other ideas?
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
Officer Krupke, what are we to do?
Gee, officer Krupke, Krup you! (West Side Story, "Gee, Officer Krupke")
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: alvherre@alvh.no-ip.org, akapila@postgresql.org, sawada.mshk@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP.
In-Reply-To: <20220904081821.bck6q2j6gfp3p2im@alvherre.pgsql>
References: <E1nWTkh-000ncF-2O@gemulon.postgresql.org> <20220904081821.bck6q2j6gfp3p2im@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox