pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add support for COPY TO callback functions
Date: Tue, 11 Oct 2022 15:42:21 -0700
Message-ID: <20221011224221.dvg5q7e7vhjdtcvv@awork3.anarazel.de> (raw)
In-Reply-To: <E1oi5JD-001pmx-Gv@gemulon.postgresql.org>
References: <E1oi5JD-001pmx-Gv@gemulon.postgresql.org>

Hi,

On 2022-10-11 02:47:56 +0000, Michael Paquier wrote:
> Add support for COPY TO callback functions
> 
> This is useful as a way for extensions to process COPY TO rows in the
> way they see fit (say auditing, analytics, backend, etc.) without the
> need to invoke an external process running as the OS user running the
> backend through PROGRAM that requires superuser rights.  COPY FROM
> already provides a similar callback for logical replication.  For COPY
> TO, the callback is triggered when we are ready to send a row in
> CopySendEndOfRow(), which is the same code path as when sending a row
> to a frontend or a pipe/file.
> 
> A small test module, test_copy_callbacks, is added to provide some
> coverage for this facility.

New warning with msvc 2022:

C:\dev\postgres-meson\src\test\modules\test_copy_callbacks\test_copy_callbacks.c(40,73): warning C4047: 'function': 'bool' differs in levels of indirection from 'void *' [C:\dev\postgres-meson\build-msbuild-2022\src\test\modules\test_copy_callbacks\7d667bc@@test_copy_callbacks@sha.vcxproj]
C:\dev\postgres-meson\src\test\modules\test_copy_callbacks\test_copy_callbacks.c(40,69): warning C4024: 'BeginCopyTo': different types for formal and actual parameter 6 [C:\dev\postgres-meson\build-msbuild-2022\src\test\modules\test_copy_callbacks\7d667bc@@test_copy_callbacks@sha.vcxproj]

Looks quite justified. Passing NULL to bool is_program isn't right.

Greetings,

Andres Freund





view thread (3+ messages)  latest in thread

Message-ID: <20221011224221.dvg5q7e7vhjdtcvv@awork3.anarazel.de>
Permalink:  ../20221011224221.dvg5q7e7vhjdtcvv@awork3.anarazel.de/
Also on:    postgresql.org/message-id/20221011224221.dvg5q7e7vhjdtcvv@awork3.anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, michael@paquier.xyz
  Subject: Re: pgsql: Add support for COPY TO callback functions
  In-Reply-To: <20221011224221.dvg5q7e7vhjdtcvv@awork3.anarazel.de>
  References: <E1oi5JD-001pmx-Gv@gemulon.postgresql.org> <20221011224221.dvg5q7e7vhjdtcvv@awork3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox