From: Andres Freund <andres@anarazel.de>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org, Nazir Bilal Yavuz <byavuz81@gmail.com>
Subject: Re: pg_upgrade test failure
Date: Tue, 18 Oct 2022 09:29:08 -0700
Message-ID: <20221018162908.cb3n7tahtekypbkf@awork3.anarazel.de> (raw)
In-Reply-To: <20221018043144.GF7745@telsasoft.com>
References: <20220919213217.ptqfdlcc5idk5xup@awork3.anarazel.de>
<20220920013122.GA31833@telsasoft.com>
<CA+hUKGJSkt3nx35uwpYX8D+cAZT38gk++btCp2Tz+uibH+Y1PA@mail.gmail.com>
<CA+hUKG+H-q78LxD20UOVyJbP1_idyocj6va_v1TF4RnN9JZa+w@mail.gmail.com>
<YzovdL3lqhmorvl0@paquier.xyz>
<CA+hUKG+bk4KGwYT4JrZEdAgNdFm-c8ezTrxf-PacS-npQ_HdSw@mail.gmail.com>
<YzqBIzMwoBiESmkk@paquier.xyz>
<CA+hUKGKsdzw06c5nnb=KYG9GmvyykoVpJA_VR3k0r7cZOKcx6Q@mail.gmail.com>
<Y04mN0ZLNzJywrad@paquier.xyz>
<20221018043144.GF7745@telsasoft.com>
Hi,
On 2022-10-17 23:31:44 -0500, Justin Pryzby wrote:
> On Tue, Oct 18, 2022 at 01:06:15PM +0900, Michael Paquier wrote:
> > On Tue, Oct 18, 2022 at 09:47:37AM +1300, Thomas Munro wrote:
> > > * Server 2019, as used on CI, still uses the traditional NT semantics
> > > (unlink is asynchronous, when all handles closes)
> > > * the fix I proposed has the right effect (I will follow up with tests
> > > to demonstrate)
> >
> > Wow, nice investigation. And cirrus does not offer a newer option
> > either..
>
> Currently Andres builds images based on cirrus's 2019 image, but I think
> we could use any windows docker image.
You unfortunately can't run newer containers than the host OS :(, just user
older ones. And if you use mismatching containers the startup gets slower
because it switches to use full virtualization rather than containers.
I think we need to switch to use full VMs rather than containers. The
performance of the windows containers is just atrocious (build times on a
local VM with the same number of cores is 1/2 of what we see in CI, test times
1/3), they're slow to start due to pulling all files and decompressing them,
and they're fragile. I've asked Bilal (CCed) to work on generating both
containers and images.
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, pryzby@telsasoft.com, michael@paquier.xyz, thomas.munro@gmail.com, byavuz81@gmail.com
Subject: Re: pg_upgrade test failure
In-Reply-To: <20221018162908.cb3n7tahtekypbkf@awork3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox