From: Julien Rouhaud <rjuju123@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Refactor code handling the names of files loaded in hba.c
Date: Wed, 26 Oct 2022 11:27:30 +0800
Message-ID: <20221026032730.k3sib5krgm7l6njk@jrouhaud> (raw)
In-Reply-To: <E1onWXT-000pTR-R4@gemulon.postgresql.org>
References: <E1onWXT-000pTR-R4@gemulon.postgresql.org>
Hi,
On Wed, Oct 26, 2022 at 02:53:08AM +0000, Michael Paquier wrote:
> Refactor code handling the names of files loaded in hba.c
For the record there is a couple of thinko in the extracted patch:
@@ -1063,6 +1064,7 @@ HbaLine *
parse_hba_line(TokenizedAuthLine *tok_line, int elevel)
{
int line_num = tok_line->line_num;
+ char *file_name = tok_line->file_name;
char **err_msg = &tok_line->err_msg;
char *str;
struct addrinfo *gai_result;
@@ -1077,6 +1079,7 @@ parse_hba_line(TokenizedAuthLine *tok_line, int elevel)
HbaLine *parsedline;
parsedline = palloc0(sizeof(HbaLine));
+ parsedline->sourcefile = pstrdup(tok_line->file_name);
This should have used the "file_name" variable rather than accessing it via
tok_line, same for parse_ident_line.
I fixed it in the v14 sent on the main thread, unfortunately sent a bit too
late.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: rjuju123@gmail.com, michael@paquier.xyz
Subject: Re: pgsql: Refactor code handling the names of files loaded in hba.c
In-Reply-To: <20221026032730.k3sib5krgm7l6njk@jrouhaud>
References: <E1onWXT-000pTR-R4@gemulon.postgresql.org> <20221026032730.k3sib5krgm7l6njk@jrouhaud>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox