pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Resolve partition strategy during early parsing
3+ messages / 3 participants
[nested] [flat]
Commits from this thread:
2022-11-07 1613de8bc3 Fix compiler warning on MSVC
* pgsql: Resolve partition strategy during early parsing
@ 2022-11-03 15:41 Alvaro Herrera <alvherre@alvh.no-ip.org>
0 siblings, 1 reply; 3+ messages in thread
From: Alvaro Herrera @ 2022-11-03 15:41 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Resolve partition strategy during early parsing
This has little practical value, but there's no reason to let the
partition strategy names travel through DDL as strings.
Reviewed-by: Japin Li <japinli@hotmail.com>
Discussion: https://postgr.es/m/20221021093216.ffupd7epy2mytkux@alvherre.pgsql
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/5fca91025e05f803140831953c09a36f08efcef5
Modified Files
--------------
src/backend/commands/tablecmds.c | 35 +++++++++++------------------------
src/backend/parser/gram.y | 22 +++++++++++++++++++++-
src/backend/partitioning/partbounds.c | 27 +++++----------------------
src/backend/utils/cache/partcache.c | 6 ++++++
src/include/nodes/parsenodes.h | 15 ++++++++-------
src/include/partitioning/partbounds.h | 2 +-
src/include/utils/partcache.h | 3 ++-
7 files changed, 54 insertions(+), 56 deletions(-)
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: Resolve partition strategy during early parsing
@ 2022-11-04 16:19 Justin Pryzby <pryzby@telsasoft.com>
parent: Alvaro Herrera <alvherre@alvh.no-ip.org>
0 siblings, 1 reply; 3+ messages in thread
From: Justin Pryzby @ 2022-11-04 16:19 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@alvh.no-ip.org>; +Cc: pgsql-committers@lists.postgresql.org
On Thu, Nov 03, 2022 at 03:41:56PM +0000, Alvaro Herrera wrote:
> Resolve partition strategy during early parsing
>
> This has little practical value, but there's no reason to let the
> partition strategy names travel through DDL as strings.
>
> Reviewed-by: Japin Li <japinli@hotmail.com>
> Discussion: https://postgr.es/m/20221021093216.ffupd7epy2mytkux@alvherre.pgsql
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/5fca91025e05f803140831953c09a36f08efcef5
This caused a warning in MSVC.
[16:10:46.225] c:\cirrus\src\backend\parser\gram.y(18435) : warning C4715: 'parsePartitionStrategy': not all control paths return a value
I'll send a patch to make cfbot warn about that soon.
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: Resolve partition strategy during early parsing
@ 2022-11-07 21:55 David Rowley <dgrowleyml@gmail.com>
parent: Justin Pryzby <pryzby@telsasoft.com>
0 siblings, 0 replies; 3+ messages in thread
From: David Rowley @ 2022-11-07 21:55 UTC (permalink / raw)
To: Justin Pryzby <pryzby@telsasoft.com>; +Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>; pgsql-committers@lists.postgresql.org
On Sat, 5 Nov 2022 at 05:19, Justin Pryzby <pryzby@telsasoft.com> wrote:
> [16:10:46.225] c:\cirrus\src\backend\parser\gram.y(18435) : warning C4715: 'parsePartitionStrategy': not all control paths return a value
I noticed this too. I've just pushed a patch to fix it.
David
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2022-11-07 21:55 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-11-03 15:41 pgsql: Resolve partition strategy during early parsing Alvaro Herrera <alvherre@alvh.no-ip.org>
2022-11-04 16:19 ` Justin Pryzby <pryzby@telsasoft.com>
2022-11-07 21:55 ` David Rowley <dgrowleyml@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox