pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Get rid of the "new" and "old" entries in a view's rangetable.
Date: Wed, 18 Jan 2023 12:14:51 -0800
Message-ID: <20230118201451.f2dooawchsfy57qc@awork3.anarazel.de> (raw)
In-Reply-To: <3787913.1674072518@sss.pgh.pa.us>
References: <E1pID77-004KBV-9p@gemulon.postgresql.org>
	<20230118195855.7yjc4mminmv7iyy5@awork3.anarazel.de>
	<3787913.1674072518@sss.pgh.pa.us>

Hi,

On 2023-01-18 15:08:38 -0500, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > On 2023-01-18 18:24:45 +0000, Tom Lane wrote:
> >> Get rid of the "new" and "old" entries in a view's rangetable.
> 
> > This seems to have caused a test failure on windows. Looks like it's not
> > indicating a real problem, just that collate.windows.win1252.out needs to be
> > adapted.
> 
> Huh, I wonder why the cfbot never complained about that when
> it was testing this patch ... maybe it doesn't use win1252?

This is the same environment that cfbot is also using, so this is odd. And
cfbot has been failing on windows since the commit went into master:

https://cirrus-ci.com/github/postgresql-cfbot/postgresql/

So I guess something must have changed in the patch since then? I guess it
could be that something changed on the VM, but I don't think so...

Greetings,

Andres Freund





view thread (9+ messages)  latest in thread

Message-ID: <20230118201451.f2dooawchsfy57qc@awork3.anarazel.de>
Permalink:  ../20230118201451.f2dooawchsfy57qc@awork3.anarazel.de/
Also on:    postgresql.org/message-id/20230118201451.f2dooawchsfy57qc@awork3.anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Get rid of the "new" and "old" entries in a view's rangetable.
  In-Reply-To: <20230118201451.f2dooawchsfy57qc@awork3.anarazel.de>
  References: <E1pID77-004KBV-9p@gemulon.postgresql.org> <20230118195855.7yjc4mminmv7iyy5@awork3.anarazel.de> <3787913.1674072518@sss.pgh.pa.us> <20230118201451.f2dooawchsfy57qc@awork3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox