From: Andres Freund <andres@anarazel.de>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: issue with meson builds on msys2
Date: Wed, 3 May 2023 11:26:15 -0700
Message-ID: <20230503182615.anh3al32dpgg4kox@awork3.anarazel.de> (raw)
In-Reply-To: <236c0354-62b1-0ae1-a252-4c866bc1c5d6@dunslane.net>
References: <E1poQg3-003Xv9-UZ@gemulon.postgresql.org>
<08dd6053-deee-52e9-954b-eb69232905c9@dunslane.net>
<2506819.1681761221@sss.pgh.pa.us>
<7d7dcc20-ba19-5340-9be8-f255e8b42edc@dunslane.net>
<20230420150652.jciazjap223iznjp@awork3.anarazel.de>
<5bddd941-9819-6655-7a71-3f346050583e@dunslane.net>
<6efeb45a-07f9-2291-c8f8-9fb4abbb6ebc@dunslane.net>
<20230427221828.2qo7z4xb4f7islln@awork3.anarazel.de>
<236c0354-62b1-0ae1-a252-4c866bc1c5d6@dunslane.net>
Hi,
On 2023-05-03 09:20:28 -0400, Andrew Dunstan wrote:
> On 2023-04-27 Th 18:18, Andres Freund wrote:
> > Hi,
> >
> > On 2023-04-26 09:59:05 -0400, Andrew Dunstan wrote:
> > > Still running into this, and I am rather stumped. This is a blocker for
> > > buildfarm support for meson:
> > >
> > > Here's a simple illustration of the problem. If I do the identical test with
> > > a non-meson build there is no problem:
> > This happens 100% reproducible?
> For a sufficiently modern installation of msys2 (20230318 version) this is
> reproducible on autoconf builds as well.
Oh. Seems like something we need to dig into independent of meson then :(
> The main thing that's now an issue on Windows is support for various options
> like libxml2. I installed the libxml2 distro from the package manager scoop,
> generated .lib files for the libxml2 and libxslt DLLs, and was able to build
> with autoconf on msys2, and with our MSVC support, but not with meson in
> either case. It looks like we need to expand the logic in meson.build for a
> number of these, just as we have done for perl, python, openssl, ldap etc.
I seriously doubt that trying to support every possible packaging thing on
windows is a good idea. What's the point of building against libraries from a
packaging solution that doesn't even come with .lib files? Windows already is
a massive pain to support for postgres, making it even more complicated / less
predictable is a really bad idea.
IMO, for windows, the path we should go down is to provide one documented way
to build the dependencies (e.g. using vcpkg or conan, perhaps also supporting
msys distributed libs), and define using something else to be unsupported (in
the "we don't help you", not in the "we explicitly try to break things"
sense). And it should be something that understands needing to build debug
and non-debug libraries.
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, andrew@dunslane.net, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Subject: Re: issue with meson builds on msys2
In-Reply-To: <20230503182615.anh3al32dpgg4kox@awork3.anarazel.de>
References: <E1poQg3-003Xv9-UZ@gemulon.postgresql.org> <08dd6053-deee-52e9-954b-eb69232905c9@dunslane.net> <2506819.1681761221@sss.pgh.pa.us> <7d7dcc20-ba19-5340-9be8-f255e8b42edc@dunslane.net> <20230420150652.jciazjap223iznjp@awork3.anarazel.de> <5bddd941-9819-6655-7a71-3f346050583e@dunslane.net> <6efeb45a-07f9-2291-c8f8-9fb4abbb6ebc@dunslane.net> <20230427221828.2qo7z4xb4f7islln@awork3.anarazel.de> <236c0354-62b1-0ae1-a252-4c866bc1c5d6@dunslane.net> <20230503182615.anh3al32dpgg4kox@awork3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox