pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: issue with meson builds on msys2
Date: Mon, 15 May 2023 13:13:26 -0700
Message-ID: <20230515201326.tbjgfdef6ul6oqfd@awork3.anarazel.de> (raw)
In-Reply-To: <26b0ebdb-3e7c-d562-620d-8e2f17286ff9@dunslane.net>
References: <7d7dcc20-ba19-5340-9be8-f255e8b42edc@dunslane.net>
	<20230420150652.jciazjap223iznjp@awork3.anarazel.de>
	<5bddd941-9819-6655-7a71-3f346050583e@dunslane.net>
	<6efeb45a-07f9-2291-c8f8-9fb4abbb6ebc@dunslane.net>
	<20230427221828.2qo7z4xb4f7islln@awork3.anarazel.de>
	<236c0354-62b1-0ae1-a252-4c866bc1c5d6@dunslane.net>
	<20230504235413.eibaxlxslo76ipjl@awork3.anarazel.de>
	<2ff71af4-cdee-37b8-525a-2b25afd1769a@dunslane.net>
	<20230515193817.ttx4qf3ceqeufls2@awork3.anarazel.de>
	<26b0ebdb-3e7c-d562-620d-8e2f17286ff9@dunslane.net>

Hi,

On 2023-05-15 16:01:39 -0400, Andrew Dunstan wrote:
> On 2023-05-15 Mo 15:38, Andres Freund wrote:
> > Hi,
> > 
> > On 2023-05-05 07:08:39 -0400, Andrew Dunstan wrote:
> > > If you want to play I can arrange access.
> > Andrew did - thanks!
> > 
> > 
> > A first observeration is that making the shell command slightly more
> > complicated, by echoing $? after pg_ctl, prevents the error:
> > 
> > /usr/bin/perl -e 'system(qq{"bin/pg_ctl" -D data-C -w -l logfile start > startlog 2>&1}) ;system(qq{"bin/pg_ctl" -D data-C -w -l logfile stop > stoplog 2>&1;}) ; print $? ? "BANG: $?\n" : "OK\n";'
> > BANG: 33280
> > 
> > /usr/bin/perl -e 'system(qq{"bin/pg_ctl" -D data-C -w -l logfile start > startlog 2>&1}) ;system(qq{"bin/pg_ctl" -D data-C -w -l logfile stop > stoplog 2>&1; echo $?}) ; print $? ? "BANG: $?\n" : "OK\n";'
> > 0
> > OK
> 
> 
> You're now testing something else, namely the return of the echo rather than
> the call to pg_ctl, so I don't think this is any kind of answer. It would
> just be ignoring the result of pg_ctl.

It wouldn't really - the echo $? inside the system() would report the
error. Which it doesn't - note the "0" in the second output.


> > Andrew, is it ok if modify pg_ctl.c and rebuild? I don't know how "detached"
> > from the actual buildfarm animal the system you gave me access to is...
> > 
> 
> Feel free to do anything you want. This is a completely separate instance
> from the buildfarm animals. When we're done with this issue the EC2 instance
> will go away.

Thanks!

Greetings,

Andres Freund





view thread (24+ messages)  latest in thread

Message-ID: <20230515201326.tbjgfdef6ul6oqfd@awork3.anarazel.de>
Permalink:  ../20230515201326.tbjgfdef6ul6oqfd@awork3.anarazel.de/
Also on:    postgresql.org/message-id/20230515201326.tbjgfdef6ul6oqfd@awork3.anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, andrew@dunslane.net, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
  Subject: Re: issue with meson builds on msys2
  In-Reply-To: <20230515201326.tbjgfdef6ul6oqfd@awork3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox