From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Andres Freund <andres@anarazel.de>
Cc: Christoph Berg <myon@debian.org>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: could not extend file "base/5/3501" with FileFallocate(): Interrupted system call
Date: Tue, 6 Jun 2023 21:53:00 +0200
Message-ID: <20230606195300.wackhn5qc7nic5l5@alvherre.pgsql> (raw)
In-Reply-To: <20230425001623.im5uquriqlk4ayy6@awork3.anarazel.de>
On 2023-Apr-24, Andres Freund wrote:
> A prototype of that approach is attached. I pushed the retry handling into the
> pg_* routines where applicable. I guess we could add pg_* routines for
> FileFallocate(), FilePrewarm() etc as well, but I didn't do that here.
>
> Christoph, could you verify this fixes your issue?
So, is anyone making progress on this? I don't see anything in the
thread.
On adding the missing pg_* wrappers: I think if we don't (and we leave
the retry loops at the File* layer), then the risk is that some external
code would add calls to the underlying File* routines trusting them to
do the retrying, which would then become broken when we move the retry
loops to the pg_* wrappers when we add them. That doesn't seem terribly
serious to me.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"El Maquinismo fue proscrito so pena de cosquilleo hasta la muerte"
(Ijon Tichy en Viajes, Stanislaw Lem)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: alvherre@alvh.no-ip.org, andres@anarazel.de, myon@debian.org, thomas.munro@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: could not extend file "base/5/3501" with FileFallocate(): Interrupted system call
In-Reply-To: <20230606195300.wackhn5qc7nic5l5@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox