From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: shveta malik <shveta.malik@gmail.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Amit Kapila <akapila@postgresql.org>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Track last_inactive_time in pg_replication_slots.
Date: Tue, 26 Mar 2024 08:39:52 +0100
Message-ID: <202403260739.udlp7lxixktx@alvherre.pgsql> (raw)
In-Reply-To: <CAA4eK1K9S=1B_5HgitrZKz1-E=69t9RWgZK6s8eoYuBwkoSfpg@mail.gmail.com>
On 2024-Mar-26, Amit Kapila wrote:
> We have a consensus on inactive_since, so I'll make that change.
Sounds reasonable. So this is a timestamptz if the slot is inactive,
NULL if active, right? What value is it going to have for sync slots?
> I would also like to solicit your opinion on the other slot-level
> parameter we are planning to introduce. This new slot-level parameter
> will be named as inactive_timeout.
Maybe inactivity_timeout?
> This will indicate that once the slot is inactive for the
> inactive_timeout period, we will invalidate the slot. We are also
> discussing to have this parameter (inactive_timeout) as GUC [1]. We
> can have this new parameter both at the slot level and as well as a
> GUC, or just one of those.
replication_slot_inactivity_timeout?
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
Tom: There seems to be something broken here.
Teodor: I'm in sackcloth and ashes... Fixed.
http://postgr.es/m/482D1632.8010507@sigaev.ru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: alvherre@alvh.no-ip.org, amit.kapila16@gmail.com, robertmhaas@gmail.com, bertranddrouvot.pg@gmail.com, shveta.malik@gmail.com, bharath.rupireddyforpostgres@gmail.com, akapila@postgresql.org, pgsql-hackers@postgresql.org
Subject: Re: pgsql: Track last_inactive_time in pg_replication_slots.
In-Reply-To: <202403260739.udlp7lxixktx@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox