pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Melanie Plageman <melanieplageman@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Consolidate docs for vacuum-related GUCs in new subsection
Date: Mon, 13 Jan 2025 21:46:40 +0100
Message-ID: <202501132046.m4mcvxxswznu@alvherre.pgsql> (raw)
In-Reply-To: <CAAKRu_Z15QyTX5n-u4mdXbCWZAw4Y-XNrpQaxL7npOca7Z_PWA@mail.gmail.com>

On 2025-Jan-13, Melanie Plageman wrote:

> Since I didn't hear back about this and I don't see an obvious
> alternative reorganization in guc_tables.c, I plan to just push the
> attached patch that updates only postgresql.conf.sample.

Apologies, I was very unclear -- I didn't want to talk about the
ordering of entries in the code, but the categorization.  See the
config_group_names list in guc_tables.c, which defines some groups.
Each setting belongs into a group, and those groups correspond to what
the sample config file lists as section/subsection titles and to the
grouping in the docs.  Also, this categorization affects how the entries
are listed in the pg_settings view and in "postgres --describe-config",
which feed from the same tables.

Perhaps with your changes (assuming I read your commit message right),
we need new groups:
VACUUMING
VACUUMING_FREEZING
VACUUMING_AUTOVACUUM

Thanks

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"Doing what he did amounts to sticking his fingers under the hood of the
implementation; if he gets his fingers burnt, it's his problem."  (Tom Lane)





view thread (14+ messages)  latest in thread

Message-ID: <202501132046.m4mcvxxswznu@alvherre.pgsql>
Permalink:  ../202501132046.m4mcvxxswznu@alvherre.pgsql/
Also on:    postgresql.org/message-id/202501132046.m4mcvxxswznu@alvherre.pgsql

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org, melanieplageman@gmail.com, tgl@sss.pgh.pa.us, daniel@yesql.se, pgsql-hackers@lists.postgresql.org
  Subject: Re: pgsql: Consolidate docs for vacuum-related GUCs in new subsection
  In-Reply-To: <202501132046.m4mcvxxswznu@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox