public inbox for [email protected]  
help / color / mirror / Atom feed
pgsql: refactor: re-add ATExecAlterChildConstr()
2+ messages / 2 participants
[nested] [flat]

* pgsql: refactor: re-add ATExecAlterChildConstr()
@ 2025-03-11 07:48 Peter Eisentraut <[email protected]>
  2025-03-11 09:09 ` Re: pgsql: refactor: re-add ATExecAlterChildConstr() Álvaro Herrera <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Peter Eisentraut @ 2025-03-11 07:48 UTC (permalink / raw)
  To: [email protected]

refactor: re-add ATExecAlterChildConstr()

ATExecAlterChildConstr() was removed in commit 80d7f990496, but it is
needed in some subsequent patches for the NOT ENFORCED feature, to
recurse over child constraints.  This adds it back in slightly altered
form.

Author: Amul Sul <[email protected]>
Reviewed-by: Alexandra Wang <[email protected]>
Discussion: https://www.postgresql.org/message-id/flat/CAAJ_b962c5AcYW9KUt_R_ER5qs3fUGbe4az-SP-vuwPS-w-AGA%40mai...

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/64224a834ce4c899e878db27b14ea3412a6ddbed

Modified Files
--------------
src/backend/commands/tablecmds.c | 84 ++++++++++++++++++++++++++--------------
1 file changed, 54 insertions(+), 30 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: pgsql: refactor: re-add ATExecAlterChildConstr()
  2025-03-11 07:48 pgsql: refactor: re-add ATExecAlterChildConstr() Peter Eisentraut <[email protected]>
@ 2025-03-11 09:09 ` Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Álvaro Herrera @ 2025-03-11 09:09 UTC (permalink / raw)
  To: Peter Eisentraut <[email protected]>; +Cc: [email protected]

On 2025-Mar-11, Peter Eisentraut wrote:

> refactor: re-add ATExecAlterChildConstr()
> 
> ATExecAlterChildConstr() was removed in commit 80d7f990496, but it is
> needed in some subsequent patches for the NOT ENFORCED feature, to
> recurse over child constraints.  This adds it back in slightly altered
> form.

FWIW I disagree with this approach and I think this particular piece
should not be committed until we have clarity on what is 0008 going to
actually do.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"No tengo por qué estar de acuerdo con lo que pienso"
                             (Carlos Caszeli)






^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2025-03-11 09:09 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-03-11 07:48 pgsql: refactor: re-add ATExecAlterChildConstr() Peter Eisentraut <[email protected]>
2025-03-11 09:09 ` Álvaro Herrera <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox