From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Prevent infinity and NaN in jsonb/plperl transform
Date: Mon, 30 Apr 2018 13:56:06 -0400
Message-ID: <21194.1525110966@sss.pgh.pa.us> (raw)
In-Reply-To: <E1fDCX9-0005yu-7q@gemulon.postgresql.org>
References: <E1fDCX9-0005yu-7q@gemulon.postgresql.org>
Peter Eisentraut <peter_e@gmx.net> writes:
> Prevent infinity and NaN in jsonb/plperl transform
So this isn't working on Windows:
contrib/jsonb_plperl/jsonb_plperl.c(226): warning C4013: 'isnan' undefined; assuming extern returning int [c:\pgbuildfarm\pgbuildroot\HEAD\pgsql.build\jsonb_plperl.vcxproj]
...
.\Release\jsonb_plperl\jsonb_plperl.dll : fatal error LNK1120: 1 unresolved externals [c:\pgbuildfarm\pgbuildroot\HEAD\pgsql.build\jsonb_plperl.vcxproj]
The reason seems to be this kluge in plperl.h:
/* stop perl headers from hijacking stdio and other stuff on Windows */
#ifdef WIN32
#define WIN32IO_IS_STDIO
/*
* isnan is defined in both the perl and mingw headers. We don't use it,
* so this just clears up the compile warning.
*/
#ifdef isnan
#undef isnan
#endif
#endif /* WIN32 */
Looks like the half-life of that hack just expired. What shall
we do about it?
If you don't have an immediate solution, please revert this commit
temporarily, as it's preventing me from making any further progress
on the reattach-failure investigation.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter_e@gmx.net, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Prevent infinity and NaN in jsonb/plperl transform
In-Reply-To: <21194.1525110966@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox