From: Tom Lane <tgl@sss.pgh.pa.us>
To: Magnus Hagander <magnus@hagander.net>
Cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Suppress uninitialized-variable warning.
Date: Sun, 23 Jan 2011 13:36:31 -0500
Message-ID: <21859.1295807791@sss.pgh.pa.us> (raw)
In-Reply-To: <AANLkTin-kiwf=Pe32snOXUop5mF_Ly9cJUjHvdSTDnGR@mail.gmail.com>
References: <E1Ph4MV-0006Jg-VV@gemulon.postgresql.org>
<AANLkTikSG87z2QBWQniPshnmC+jsgWJkCwssJNsPG5Dj@mail.gmail.com>
<12484.1295806865@sss.pgh.pa.us>
<AANLkTin-kiwf=Pe32snOXUop5mF_Ly9cJUjHvdSTDnGR@mail.gmail.com>
Magnus Hagander <magnus@hagander.net> writes:
> On Sun, Jan 23, 2011 at 19:21, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Magnus Hagander <magnus@hagander.net> writes:
>>> Which compiler did that come out of? I don't think I saw it on any of
>>> the ones I tried..
>> gcc 4.4.5, standard on Fedora 13. I'm surprised that yours did not show
>> it, because the usage pattern looks beyond gcc's ability to prove safe.
> Interesting. I just make clean/make:ed it again to make sure, and it
> doesn't. And I'm on:
> gcc (Ubuntu/Linaro 4.4.4-14ubuntu5) 4.4.5
[ scratches head... ] Maybe you are using different switches, perhaps
optimization higher than -O2?
But anyway, I think the project policy for such things is that we want
to suppress warnings when feasible on all common compilers, so the patch
is appropriate no matter what the specific reason for the difference is.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, magnus@hagander.net
Subject: Re: pgsql: Suppress uninitialized-variable warning.
In-Reply-To: <21859.1295807791@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox