From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Fujii Masao <fujii@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix bug in Tid scan.
Date: Fri, 07 Feb 2020 20:04:30 -0500
Message-ID: <24554.1581123870@sss.pgh.pa.us> (raw)
In-Reply-To: <CAHGQGwFZ+KWahHGwqiJ676XHjHOoU_MKrS1gxie9zgw8pze+MQ@mail.gmail.com>
References: <E1j03Ml-0002mD-Hj@gemulon.postgresql.org>
<5261.1581103527@sss.pgh.pa.us>
<CAHGQGwFZ+KWahHGwqiJ676XHjHOoU_MKrS1gxie9zgw8pze+MQ@mail.gmail.com>
Fujii Masao <masao.fujii@gmail.com> writes:
> On Sat, Feb 8, 2020 at 4:25 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> AFAICS, this patch has caused an ABI break in v12. Do we really
>> believe that no extension references the values of the ScanOptions
>> enum?
> Yes, you are right. Some extensions may depend on it.
> It's better not to add new ScanOption not to break ABI.
I think it's okay to add a new value of ScanOption; what you can't
do is change the codes assigned to the existing values. So I'd
just revert those code changes and give SO_TYPE_TIDSCAN a value
that's out-of-order.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, masao.fujii@gmail.com, fujii@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix bug in Tid scan.
In-Reply-To: <24554.1581123870@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox